git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anders Kaseorg <andersk@MIT.EDU>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	stevenrwalter@gmail.com, normalperson@yhbt.net
Subject: Re: [RFC/PATCH] t9157-*.sh: Add an svn version check
Date: Sat, 08 Jan 2011 02:19:02 -0700	[thread overview]
Message-ID: <1294478342.2791.4.camel@fixed-disk> (raw)
In-Reply-To: <4D260A03.90903@ramsay1.demon.co.uk>

On Thu, 2011-01-06 at 18:29 +0000, Ramsay Jones wrote:
> +svn_ver="$(svn --version --quiet)"
> +case $svn_ver in
> +[0-1].[0-4].[0-6])

Thanks for the patch.  Can I suggest the more precise

0.* | 1.[0-4].*)

Anders

  parent reply	other threads:[~2011-01-08  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06 18:29 [RFC/PATCH] t9157-*.sh: Add an svn version check Ramsay Jones
2011-01-07 17:31 ` Eric Wong
2011-01-07 17:44   ` Steven Walter
2011-01-07 18:02     ` Eric Wong
2011-01-07 18:19       ` Jonathan Nieder
2011-01-07 18:39         ` Eric Wong
2011-01-07 22:22     ` Eric Wong
2011-01-07 22:32       ` Junio C Hamano
2011-01-08  9:19 ` Anders Kaseorg [this message]
2011-01-11 18:21   ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294478342.2791.4.camel@fixed-disk \
    --to=andersk@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    --cc=ramsay@ramsay1.demon.co.uk \
    --cc=stevenrwalter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).