git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] exec_cmd: remove unused extern
@ 2011-01-10 22:00 Erik Faye-Lund
  2011-03-24 10:39 ` Erik Faye-Lund
  0 siblings, 1 reply; 3+ messages in thread
From: Erik Faye-Lund @ 2011-01-10 22:00 UTC (permalink / raw)
  To: git

This definition was added by commit 77cb17e9, but it's left unused since
commit 511707d. Remove the left-over definition.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---

Just a left-over definition I found while looking through some code.

 exec_cmd.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/exec_cmd.c b/exec_cmd.c
index bf22570..38545e8 100644
--- a/exec_cmd.c
+++ b/exec_cmd.c
@@ -3,7 +3,6 @@
 #include "quote.h"
 #define MAX_ARGS	32
 
-extern char **environ;
 static const char *argv_exec_path;
 static const char *argv0_path;
 
-- 
1.7.4.rc1.3196.gfd693

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] exec_cmd: remove unused extern
  2011-01-10 22:00 [PATCH] exec_cmd: remove unused extern Erik Faye-Lund
@ 2011-03-24 10:39 ` Erik Faye-Lund
  2011-03-24 10:44   ` Erik Faye-Lund
  0 siblings, 1 reply; 3+ messages in thread
From: Erik Faye-Lund @ 2011-03-24 10:39 UTC (permalink / raw)
  To: git

On Mon, Jan 10, 2011 at 11:00 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> This definition was added by commit 77cb17e9, but it's left unused since
> commit 511707d. Remove the left-over definition.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> Just a left-over definition I found while looking through some code.
>
>  exec_cmd.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/exec_cmd.c b/exec_cmd.c
> index bf22570..38545e8 100644
> --- a/exec_cmd.c
> +++ b/exec_cmd.c
> @@ -3,7 +3,6 @@
>  #include "quote.h"
>  #define MAX_ARGS       32
>
> -extern char **environ;
>  static const char *argv_exec_path;
>  static const char *argv0_path;
>

Bump? Or is this just too insignificant?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] exec_cmd: remove unused extern
  2011-03-24 10:39 ` Erik Faye-Lund
@ 2011-03-24 10:44   ` Erik Faye-Lund
  0 siblings, 0 replies; 3+ messages in thread
From: Erik Faye-Lund @ 2011-03-24 10:44 UTC (permalink / raw)
  To: git

On Thu, Mar 24, 2011 at 11:39 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> On Mon, Jan 10, 2011 at 11:00 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
>> This definition was added by commit 77cb17e9, but it's left unused since
>> commit 511707d. Remove the left-over definition.
>>
>> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
>> ---
>>
>> Just a left-over definition I found while looking through some code.
>>
>>  exec_cmd.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/exec_cmd.c b/exec_cmd.c
>> index bf22570..38545e8 100644
>> --- a/exec_cmd.c
>> +++ b/exec_cmd.c
>> @@ -3,7 +3,6 @@
>>  #include "quote.h"
>>  #define MAX_ARGS       32
>>
>> -extern char **environ;
>>  static const char *argv_exec_path;
>>  static const char *argv0_path;
>>
>
> Bump? Or is this just too insignificant?
>

Sorry for the noise. This has already been applied, I just experienced
a brain fart while checking.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-03-24 10:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-10 22:00 [PATCH] exec_cmd: remove unused extern Erik Faye-Lund
2011-03-24 10:39 ` Erik Faye-Lund
2011-03-24 10:44   ` Erik Faye-Lund

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).