From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH v2 2/3] gitweb/gitweb.perl: remove use of qw(...) as parentheses Date: Sat, 19 Feb 2011 15:27:41 +0000 Message-ID: <1298129262-10468-3-git-send-email-avarab@gmail.com> References: <1298124654-12051-1-git-send-email-avarab@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Junio C Hamano , Jakub Narebski , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sat Feb 19 16:28:13 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PqojE-0006EQ-5z for gcvg-git-2@lo.gmane.org; Sat, 19 Feb 2011 16:28:12 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755600Ab1BSP2E convert rfc822-to-quoted-printable (ORCPT ); Sat, 19 Feb 2011 10:28:04 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:50583 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755587Ab1BSP2B (ORCPT ); Sat, 19 Feb 2011 10:28:01 -0500 Received: by eye27 with SMTP id 27so2301216eye.19 for ; Sat, 19 Feb 2011 07:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=JVahtft6zJAh/o6//RfrCKXsJAK48Xt/fYtflksdnXc=; b=Ks7iv3IDouYVjdJNK/YjSJER2DaWuS531gQCQh7ZlQar8DssmB+CWs9WBbw74nK8b5 S0VuTzIF+XrlvP8eEDKRCMyTdAfB+FGQWQyy6L3nzB+Ij+7llNbWkXmAM50+7JLNf+15 stuExEckHHbk4HokYLwbIg/psIIerho++jSI0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :mime-version:content-type:content-transfer-encoding; b=q+LFpFgmsezTDOfTW09zqRCanEnNadlsufxIpCHRuEcAql28hyIEnVMTZuiMstpons OHDiNQhhSNr/iYGNRofZ/+pYhHwAxCPv8TAJoMMaondhSITQuWInuuevXROVP9A3IcQR rlDIbkhPsR7hSH9rJYqhgIrS7ERDi6/3yv794= Received: by 10.14.127.200 with SMTP id d48mr2258569eei.4.1298129280196; Sat, 19 Feb 2011 07:28:00 -0800 (PST) Received: from w.nix.is (w.nix.is [188.40.98.140]) by mx.google.com with ESMTPS id q52sm3006362eei.15.2011.02.19.07.27.59 (version=SSLv3 cipher=OTHER); Sat, 19 Feb 2011 07:27:59 -0800 (PST) X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1298124654-12051-1-git-send-email-avarab@gmail.com> In-Reply-To: <1298124654-12051-1-git-send-email-avarab@gmail.com> References: <1298124654-12051-1-git-send-email-avarab@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Using the qw(...) construct as implicit parentheses was deprecated in perl 5.13.5. Change the relevant code in gitweb to not use the deprecated construct. The offending code was introduced in 3562198b by Jakub Narebski. The issue is that perl will now warn about this: $ perl -wE 'for my $i qw(a b) { say $i }' Use of qw(...) as parentheses is deprecated at -e line 1. a b This caused gitweb.perl to warn on perl 5.13.5 and above, and these tests to fail on those perl versions: ./t9501-gitweb-standalone-http-status.sh (Wstat: 256 Test= s: 11 Failed: 10) Failed tests: 2-11 Non-zero exit status: 1 ./t9502-gitweb-standalone-parse-output.sh (Wstat: 256 Test= s: 10 Failed: 9) Failed tests: 2-10 Non-zero exit status: 1 Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason --- gitweb/gitweb.perl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 0779f12..b02372c 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3501,7 +3501,7 @@ sub print_feed_meta { $href_params{'-title'} =3D 'log'; } =20 - foreach my $format qw(RSS Atom) { + foreach my $format (qw(RSS Atom)) { my $type =3D lc($format); my %link_attr =3D ( '-rel' =3D> 'alternate', @@ -3682,7 +3682,7 @@ sub git_footer_html { } $href_params{'-title'} ||=3D 'log'; =20 - foreach my $format qw(RSS Atom) { + foreach my $format (qw(RSS Atom)) { $href_params{'action'} =3D lc($format); print $cgi->a({-href =3D> href(%href_params), -title =3D> "$href_params{'-title'} $format feed", --=20 1.7.2.3