From: Andrey Borzenkov <arvidjaar@gmail.com>
To: git@vger.kernel.org
Subject: [TopGit PATCH] tg-create: let format.signoff control adding of Signed-off-by
Date: Mon, 7 Mar 2011 13:42:46 +0300 [thread overview]
Message-ID: <1299494566-13021-1-git-send-email-arvidjaar@gmail.com> (raw)
GIT manual stresses that adding of Signed-off-by should be explicit
user decision. Some projects do ask for no Signed-off-by lines. So
make sure it is added by tg-create.sh only when explicity requested
by user.
Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>
---
tg-create.sh | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/tg-create.sh b/tg-create.sh
index 2edd537..617031b 100644
--- a/tg-create.sh
+++ b/tg-create.sh
@@ -129,11 +129,9 @@ author_addr="${author%> *}>"
! subject_prefix="$(git config topgit.subjectprefix)" || subject_prefix="$subject_prefix "
echo "Subject: [${subject_prefix}PATCH] $name"
echo
- cat <<EOT
-<patch description>
-
-Signed-off-by: $author_addr
-EOT
+ echo '<patch description>'
+ echo
+ [ "$(git config --bool format.signoff)" = true ] && echo "Signed-off-by: $author_addr"
} >"$root_dir/.topmsg"
git add -f "$root_dir/.topmsg"
--
tg: (d279e29..) u/signed-off-by (depends on: master)
reply other threads:[~2011-03-07 10:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299494566-13021-1-git-send-email-arvidjaar@gmail.com \
--to=arvidjaar@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).