git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [WIP PATCH 0/5] support --exclude for diff/log commands
Date: Thu, 10 Mar 2011 10:13:34 +0700	[thread overview]
Message-ID: <1299726819-5576-1-git-send-email-pclouds@gmail.com> (raw)

This is not really ready for review or use, but I'd like to have
feedback if any, where this series is heading because it requires some
code refactor in diff/rev machinery. It does not feel absolutely right
to me.

On the other hand, if we go with ':' as a mark of special pathspecs, then

 - ":/" mark pathspecs relative to worktree root
 - ":!" may mark negative pathspecs

Less changes in diff/rev this way.

Nguyễn Thái Ngọc Duy (5):
  tree-walk: support negative pathspec
  match_pathspec_depth: support negative pathspec

match_pathspec_depth needs work. tree_entry_interesting() can use some
optimization, but leave it for now.

  revision.c: get rid of struct rev_info.prune_data
  diff: refactor init/release API

These two facilitate post pathspec manipulation to transform --exclude
to pathspecs with to_exclude = 1.

  diff: support --exclude

 Documentation/technical/api-diff.txt |    2 +-
 builtin/add.c                        |    3 +-
 builtin/blame.c                      |   22 +++++----------
 builtin/diff.c                       |    6 ++--
 builtin/fast-export.c                |    2 +-
 builtin/merge.c                      |    2 +-
 builtin/reset.c                      |    4 +-
 cache.h                              |    1 +
 diff-lib.c                           |    6 ++--
 diff-no-index.c                      |    6 ++--
 diff.c                               |   49 ++++++++++++++++++++++++++++++++-
 diff.h                               |    6 ++--
 dir.c                                |    5 +++
 merge-recursive.c                    |    2 +-
 notes-merge.c                        |    8 +++---
 patch-ids.c                          |    2 +-
 revision.c                           |   22 ++++++++-------
 revision.h                           |    1 -
 tree-diff.c                          |   21 +++------------
 tree-walk.c                          |   37 +++++++++++++++++++------
 wt-status.c                          |    6 +---
 21 files changed, 130 insertions(+), 83 deletions(-)

-- 
1.7.3.1.256.g2539c.dirty

             reply	other threads:[~2011-03-10  3:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10  3:13 Nguyễn Thái Ngọc Duy [this message]
2011-03-10  3:13 ` [PATCH 1/5] tree-walk: support negative pathspec Nguyễn Thái Ngọc Duy
2011-03-10  3:13 ` [PATCH 2/5] match_pathspec_depth: " Nguyễn Thái Ngọc Duy
2011-03-10  3:13 ` [PATCH 3/5] revision.c: get rid of struct rev_info.prune_data Nguyễn Thái Ngọc Duy
2011-03-10  6:20   ` Junio C Hamano
2011-03-10  6:52     ` Nguyen Thai Ngoc Duy
2011-03-10  3:13 ` [PATCH 4/5] diff: refactor init/release API Nguyễn Thái Ngọc Duy
2011-03-10  3:13 ` [PATCH 5/5] diff: support --exclude Nguyễn Thái Ngọc Duy
2011-03-10  6:11 ` [WIP PATCH 0/5] support --exclude for diff/log commands Junio C Hamano
2011-03-10  7:03   ` Nguyen Thai Ngoc Duy
2011-03-10  8:41   ` Junio C Hamano
2011-03-10 10:05     ` Nguyen Thai Ngoc Duy
2011-03-21  4:02       ` Nguyen Thai Ngoc Duy
2011-03-21  9:45         ` Michael J Gruber
2011-03-21 10:02           ` Nguyen Thai Ngoc Duy
2011-03-22 23:59           ` Junio C Hamano
2011-03-23 12:10             ` Nguyen Thai Ngoc Duy
2011-03-23 12:18               ` Nguyen Thai Ngoc Duy
2011-03-23 12:51               ` Michael J Gruber
2011-03-23 13:34                 ` Nguyen Thai Ngoc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299726819-5576-1-git-send-email-pclouds@gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).