From: "Carlos Martín Nieto" <cmn@elego.de>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 1/3] make_absolute_path: Don't try to copy a string to itself
Date: Mon, 14 Mar 2011 20:18:36 +0100 [thread overview]
Message-ID: <1300130318-11279-2-git-send-email-cmn@elego.de> (raw)
In-Reply-To: <1300130318-11279-1-git-send-email-cmn@elego.de>
Sometimes (at least in t-0001-init.sh test 12), the return value of
make_absolute_path() is passed to it as an argument, making the first
and second arguments to strlcpy() the same, making the test fail when
run under valgrind.
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
---
This patch assumes the path returned by make_absolute_path() is never
longer than PATH_MAX, which I think is a safe assumption.
abspath.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/abspath.c b/abspath.c
index 91ca00f..9149a98 100644
--- a/abspath.c
+++ b/abspath.c
@@ -24,7 +24,7 @@ const char *make_absolute_path(const char *path)
char *last_elem = NULL;
struct stat st;
- if (strlcpy(buf, path, PATH_MAX) >= PATH_MAX)
+ if (buf != path && strlcpy(buf, path, PATH_MAX) >= PATH_MAX)
die ("Too long path: %.*s", 60, path);
while (depth--) {
--
1.7.4.1
next prev parent reply other threads:[~2011-03-14 19:33 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 19:18 [PATCH 0/3] Fix some errors reported by valgrind Carlos Martín Nieto
2011-03-14 19:18 ` Carlos Martín Nieto [this message]
2011-03-14 20:02 ` [PATCH 1/3] make_absolute_path: Don't try to copy a string to itself Jeff King
2011-03-14 20:25 ` Junio C Hamano
2011-03-14 22:02 ` Carlos Martín Nieto
2011-03-14 22:58 ` Junio C Hamano
2011-03-15 11:59 ` Carlos Martín Nieto
2011-03-15 12:40 ` Carlos Martín Nieto
2011-03-15 17:02 ` Junio C Hamano
2011-03-15 17:27 ` Carlos Martín Nieto
2011-03-16 14:16 ` Nguyen Thai Ngoc Duy
2011-03-16 14:49 ` Carlos Martín Nieto
2011-03-16 14:58 ` Nguyen Thai Ngoc Duy
2011-03-16 14:04 ` Nguyen Thai Ngoc Duy
2011-03-16 15:08 ` Carlos Martín Nieto
2011-03-14 19:18 ` [PATCH 2/3] setup_path(): Free temporary buffer Carlos Martín Nieto
2011-03-14 20:09 ` Jeff King
2011-03-14 22:18 ` Carlos Martín Nieto
2011-03-16 11:26 ` [PATCH] system_path: use a static buffer Carlos Martín Nieto
2011-03-16 15:58 ` Erik Faye-Lund
2011-03-16 16:24 ` Carlos Martín Nieto
2011-03-16 16:33 ` Carlos Martín Nieto
2011-03-16 20:43 ` Junio C Hamano
2011-03-17 11:01 ` Carlos Martín Nieto
2011-03-17 14:24 ` Carlos Martín Nieto
2011-03-18 7:25 ` Junio C Hamano
2011-03-21 9:56 ` Carlos Martín Nieto
2011-03-21 11:14 ` Jeff King
2011-03-21 15:26 ` Carlos Martín Nieto
2011-03-21 15:51 ` Jeff King
2011-03-21 15:57 ` Carlos Martín Nieto
2011-03-18 10:34 ` Nguyen Thai Ngoc Duy
2011-03-18 11:38 ` PATH_MAX (Re: [PATCH] system_path: use a static buffer) Jonathan Nieder
2011-03-18 11:54 ` Nguyen Thai Ngoc Duy
2011-03-21 9:47 ` Carlos Martín Nieto
2011-03-21 12:37 ` Lasse Makholm
2011-03-21 11:19 ` Nguyen Thai Ngoc Duy
2011-03-18 11:39 ` [PATCH 1/2] wrapper.c: add xgetcwd() Nguyễn Thái Ngọc Duy
2011-03-18 11:39 ` [PATCH 2/2] setup_gently: use xgetcwd() Nguyễn Thái Ngọc Duy
2011-03-14 20:14 ` [PATCH 2/3] setup_path(): Free temporary buffer Junio C Hamano
2011-03-14 22:01 ` Carlos Martín Nieto
2011-03-15 1:12 ` Jeff King
2011-03-15 9:32 ` [PATCH] t/README: Add a note about running commands under valgrind Carlos Martín Nieto
2011-03-15 17:06 ` Junio C Hamano
2011-03-15 17:08 ` Carlos Martín Nieto
2011-03-14 19:18 ` [PATCH 3/3] clone: Free a few paths Carlos Martín Nieto
2011-03-14 19:45 ` Jonathan Nieder
2011-03-18 7:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300130318-11279-2-git-send-email-cmn@elego.de \
--to=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).