Re: [PATCH] t/README: Add a note about running commands under valgrind

["Carlos Martín Nieto" <cmn@elego.de>]

On mar, 2011-03-15 at 10:06 -0700, Junio C Hamano wrote:
> Carlos Martín Nieto <cmn@elego.de> writes:
> 
> >  As Jeff pointed out, the test suite does use --leak-check=no. I was
> > using valgrind manually as I was chasing a different error that does
> > show up. How about adding this to the README?
> 
> > diff --git a/t/README b/t/README
> > index 78c9e65..2a73fc3 100644
> > --- a/t/README
> > +++ b/t/README
> > @@ -98,6 +98,13 @@ appropriately before running "make".
> >  	not see any output, this option implies --verbose.  For
> >  	convenience, it also implies --tee.
> >  
> > +	*NOTE*: As the git process is short-lived and some errors are
> > +	not interesting, valgrind is run with (among others) the
> > +	option --leak-check=no. In order to run a single command under
> > +	the same conditions manually, you should set GIT_VALGRIND to
> > +	point to the 't/valgrind/' directory and use the commands
> > +	under 't/valgrind/bin/'.
> 
> I think what the text says is a good addition.  If I were writing this
> myself, I would rephrase "*NOTE*:" to say "Note that ...", though, as that
> seems to be more in line with the other parts of the document.

 Good point. Should I resend?

   cmn