From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlos =?ISO-8859-1?Q?Mart=EDn?= Nieto Subject: Re: [PATCH] t/README: Add a note about running commands under valgrind Date: Tue, 15 Mar 2011 18:08:42 +0100 Message-ID: <1300208923.19100.39.camel@bee.lab.cmartin.tk> References: <1300130318-11279-1-git-send-email-cmn@elego.de> <1300130318-11279-3-git-send-email-cmn@elego.de> <7v7hc1cvdt.fsf@alter.siamese.dyndns.org> <1300140119.4320.38.camel@bee.lab.cmartin.tk> <20110315011230.GA31865@sigill.intra.peff.net> <1300181536.19100.7.camel@bee.lab.cmartin.tk> <7v8vwgb9fj.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jeff King , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Mar 15 18:08:54 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PzXjq-0005IL-66 for gcvg-git-2@lo.gmane.org; Tue, 15 Mar 2011 18:08:54 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932466Ab1CORIt convert rfc822-to-quoted-printable (ORCPT ); Tue, 15 Mar 2011 13:08:49 -0400 Received: from mx0.elegosoft.com ([88.198.54.133]:37748 "EHLO mx0.elegosoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932390Ab1CORIs (ORCPT ); Tue, 15 Mar 2011 13:08:48 -0400 Received: from localhost (localhost [127.0.0.1]) by mx0.elegosoft.com (Postfix) with ESMTP id 61CED1B4AC1; Tue, 15 Mar 2011 18:08:47 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mx0.elegosoft.com Received: from mx0.elegosoft.com ([127.0.0.1]) by localhost (mx0.elegosoft.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MEPDxAHM0f2w; Tue, 15 Mar 2011 18:08:42 +0100 (CET) Received: from [10.10.10.234] (i59F7870A.versanet.de [89.247.135.10]) by mx0.elegosoft.com (Postfix) with ESMTPSA id 086B41B4AB3; Tue, 15 Mar 2011 18:08:42 +0100 (CET) In-Reply-To: <7v8vwgb9fj.fsf@alter.siamese.dyndns.org> X-Mailer: Evolution 2.91.92 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On mar, 2011-03-15 at 10:06 -0700, Junio C Hamano wrote: > Carlos Mart=C3=ADn Nieto writes: >=20 > > As Jeff pointed out, the test suite does use --leak-check=3Dno. I = was > > using valgrind manually as I was chasing a different error that doe= s > > show up. How about adding this to the README? >=20 > > diff --git a/t/README b/t/README > > index 78c9e65..2a73fc3 100644 > > --- a/t/README > > +++ b/t/README > > @@ -98,6 +98,13 @@ appropriately before running "make". > > not see any output, this option implies --verbose. For > > convenience, it also implies --tee. > > =20 > > + *NOTE*: As the git process is short-lived and some errors are > > + not interesting, valgrind is run with (among others) the > > + option --leak-check=3Dno. In order to run a single command under > > + the same conditions manually, you should set GIT_VALGRIND to > > + point to the 't/valgrind/' directory and use the commands > > + under 't/valgrind/bin/'. >=20 > I think what the text says is a good addition. If I were writing thi= s > myself, I would rephrase "*NOTE*:" to say "Note that ...", though, as= that > seems to be more in line with the other parts of the document. Good point. Should I resend? cmn