From: "Carlos Martín Nieto" <cmn@elego.de>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] valgrind: ignore SSE-based strlen invalid reads
Date: Wed, 16 Mar 2011 10:31:14 +0100 [thread overview]
Message-ID: <1300267874-15365-1-git-send-email-cmn@elego.de> (raw)
The C library uses SSE instructions to make strlen (among others)
faster, loading 4 bytes at a time and reading past the end of the
allocated memory. This read is safe and when the strlen function is
inlined, it is (obviously) not replaced by valgrind, which reports a
false-possitive.
Tell valgrind to ignore this particular error, as the read is, in
fact, safe.
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
---
t/valgrind/default.supp | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/t/valgrind/default.supp b/t/valgrind/default.supp
index 9e013fa..327478c 100644
--- a/t/valgrind/default.supp
+++ b/t/valgrind/default.supp
@@ -43,3 +43,9 @@
fun:write_buffer
fun:write_loose_object
}
+
+{
+ ignore-sse-strlen-invalid-read-size
+ Memcheck:Addr4
+ fun:copy_ref
+}
\ No newline at end of file
--
1.7.4.1
next reply other threads:[~2011-03-16 9:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 9:31 Carlos Martín Nieto [this message]
2011-03-16 9:56 ` [PATCH] valgrind: ignore SSE-based strlen invalid reads Jonathan Nieder
2011-03-16 10:41 ` Carlos Martín Nieto
2011-03-16 10:47 ` Carlos Martín Nieto
2011-03-16 10:52 ` Jonathan Nieder
2011-03-16 11:10 ` Carlos Martín Nieto
2011-03-16 11:25 ` Jonathan Nieder
2011-03-16 11:46 ` Carlos Martín Nieto
2011-03-16 20:18 ` Junio C Hamano
2011-03-16 20:44 ` Carlos Martín Nieto
2011-03-16 22:43 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300267874-15365-1-git-send-email-cmn@elego.de \
--to=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).