From: "Carlos Martín Nieto" <cmn@elego.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] valgrind: ignore SSE-based strlen invalid reads
Date: Wed, 16 Mar 2011 11:41:33 +0100 [thread overview]
Message-ID: <1300272098.7214.5.camel@bee.lab.cmartin.tk> (raw)
In-Reply-To: <20110316095632.GA8277@elie>
On mié, 2011-03-16 at 04:56 -0500, Jonathan Nieder wrote:
> Hi Carlos,
>
> Carlos Martín Nieto wrote:
>
> > The C library uses SSE instructions to make strlen (among others)
> > faster, loading 4 bytes at a time and reading past the end of the
> > allocated memory. This read is safe and when the strlen function is
> > inlined, it is (obviously) not replaced by valgrind, which reports a
> > false-possitive.
>
> It would be GCC rather than the C library if the strlen is inlined, I
> think. Is this a distinct bug from
The strlen definition comes from the C library, as far as I know, but
I'll amend to say it's the GNU C Library that's doing weird things.
> <http://bugs.kde.org/show_bug.cgi?id=266961>? Has it been filed
> with the valgrind maintainers?
It looks like the same issue, which should also be
https://bugzilla.redhat.com/show_bug.cgi?id=518247 and
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=590640 which have
patches available. Newer versions of valgrind do not have this "bug".
cmn
next prev parent reply other threads:[~2011-03-16 10:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 9:31 [PATCH] valgrind: ignore SSE-based strlen invalid reads Carlos Martín Nieto
2011-03-16 9:56 ` Jonathan Nieder
2011-03-16 10:41 ` Carlos Martín Nieto [this message]
2011-03-16 10:47 ` Carlos Martín Nieto
2011-03-16 10:52 ` Jonathan Nieder
2011-03-16 11:10 ` Carlos Martín Nieto
2011-03-16 11:25 ` Jonathan Nieder
2011-03-16 11:46 ` Carlos Martín Nieto
2011-03-16 20:18 ` Junio C Hamano
2011-03-16 20:44 ` Carlos Martín Nieto
2011-03-16 22:43 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300272098.7214.5.camel@bee.lab.cmartin.tk \
--to=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).