From: "Carlos Martín Nieto" <cmn@elego.de>
To: kusmabite@gmail.com
Cc: git@vger.kernel.org, Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 3/3] Use the new {real,absolute}_path function names
Date: Wed, 16 Mar 2011 17:37:31 +0100 [thread overview]
Message-ID: <1300293451.7214.47.camel@bee.lab.cmartin.tk> (raw)
In-Reply-To: <AANLkTikvb0-XJKwNmaJGeJiZQzYC=_k9_MChyOgvkE1o@mail.gmail.com>
On mié, 2011-03-16 at 17:24 +0100, Erik Faye-Lund wrote:
> On Wed, Mar 16, 2011 at 5:06 PM, Carlos Martín Nieto <cmn@elego.de> wrote:
> > Use the new names for path functions in the code. Replace uses of
> > make_absolute_path with real_path, make_nonrelative_path with
> > absolute_path and make_relative_path with relative_path.
>
> Shouldn't these changes be squashed into the previous two commits so
> it'll be possible to bisect across it without getting a broken build?
Brian pointed this out in the other subthread. I'll resend.
next prev parent reply other threads:[~2011-03-16 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 16:06 [PATCH 0/3] Rename make_*_path with clearer names Carlos Martín Nieto
2011-03-16 16:06 ` [PATCH 1/3] make_absolute_path: return the input path if it points to our buffer Carlos Martín Nieto
2011-03-16 20:51 ` Junio C Hamano
2011-03-16 16:06 ` [PATCH 2/3] Name make_*_path functions more accurately Carlos Martín Nieto
2011-03-16 16:29 ` Brian Gernhardt
2011-03-16 16:42 ` Carlos Martín Nieto
2011-03-16 16:06 ` [PATCH 3/3] Use the new {real,absolute}_path function names Carlos Martín Nieto
2011-03-16 16:24 ` Erik Faye-Lund
2011-03-16 16:37 ` Carlos Martín Nieto [this message]
2011-03-16 16:52 ` [PATCH 2-3/3] Name make_*_path functions more accurately Carlos Martín Nieto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300293451.7214.47.camel@bee.lab.cmartin.tk \
--to=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).