git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Palmer <wmpalmer@gmail.com>
To: Thomas Egerer <thomas.egerer@secunet.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] pretty.c: Make user defined format honor color option
Date: Thu, 17 Mar 2011 12:59:52 +0000	[thread overview]
Message-ID: <1300366792.3269.24.camel@wpalmer.simply-domain> (raw)
In-Reply-To: <4D81F860.2070703@secunet.com>

On Thu, 2011-03-17 at 13:02 +0100, Thomas Egerer wrote:
> On 03/17/2011 10:39 AM, Will Palmer schrobtete:
> > On Thu, 2011-03-17 at 09:33 +0100, Thomas Egerer wrote:
> >> This patch fixes that the pretty-formats tformat and format ignore
> >> git's color option.
> > 
> > It is my understanding that this is intentional, the logic being: If you
> > normally don't want color, but have specified it directly on the
> > command-line, you probably want color.
> I'm using the pretty format in the context of an alias. My global setting
> for colors is auto. I would expect git to not disregard this options. I
> usually use the alias to display a git log in a modified way, but I also
> do sometimes pipe it to grep. If there was a way to suppress output
> colorization (let's say by not using global options but the command line
> switch --color=never) that would work for me. But there is no wa and I
> find it inconvinient to have two different aliases doing the same thing
> one with color and one without while there would be a much simpler way.
...snip
> Thomas

Perhaps --color=auto, specified on the command-line, should behave
differently to the various color options specified via config. That
might make both sides happy, as one could always specify --color=auto to
explicitly tell git to only color if it thinks it should.

Can anyone else refresh my memory regarding the use-case where
hand-specified colors really should have an effect even with
--color=never?

  reply	other threads:[~2011-03-17 13:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17  8:33 [PATCH] pretty.c: Make user defined format honor color option Thomas Egerer
2011-03-17  9:39 ` Will Palmer
2011-03-17 12:02   ` Thomas Egerer
2011-03-17 12:59     ` Will Palmer [this message]
2011-03-17 19:49       ` Jeff King
2011-03-17 13:46   ` Thomas Egerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300366792.3269.24.camel@wpalmer.simply-domain \
    --to=wmpalmer@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=thomas.egerer@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).