From: Stephen Boyd <bebarino@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 1/2] Makefile: Cover more files with make check
Date: Mon, 21 Mar 2011 02:45:03 -0700 [thread overview]
Message-ID: <1300700704-22674-1-git-send-email-bebarino@gmail.com> (raw)
After the builtin/ move 'make check' doesn't cover the builtin/
directory. We could just add builtin/*.c but lets just use GIT_OBJS
instead so we cover future movement of the source files.
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 654d8ac..97cd150 100644
--- a/Makefile
+++ b/Makefile
@@ -2176,7 +2176,7 @@ check-sha1:: test-sha1$X
check: common-cmds.h
if sparse; \
then \
- for i in *.c; \
+ for i in $(patsubst %.o, %.c, $(GIT_OBJS)); \
do \
sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; \
done; \
--
1.7.4.1.343.ga91df
next reply other threads:[~2011-03-21 9:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 9:45 Stephen Boyd [this message]
2011-03-21 9:45 ` [PATCH 2/2] Fix sparse warnings Stephen Boyd
2011-03-21 10:10 ` Johannes Sixt
2011-03-21 10:12 ` Stephen Boyd
2011-03-21 16:12 ` Junio C Hamano
2011-03-21 16:15 ` Junio C Hamano
2011-03-21 18:01 ` [PATCHv2 " Stephen Boyd
2011-03-21 19:29 ` Junio C Hamano
2011-03-21 21:58 ` Junio C Hamano
2011-03-21 22:04 ` Stephen Boyd
2011-03-22 7:51 ` [PATCHv3 " Stephen Boyd
2011-03-22 17:18 ` Junio C Hamano
2011-03-21 17:27 ` [PATCH 1/2] Makefile: Cover more files with make check Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300700704-22674-1-git-send-email-bebarino@gmail.com \
--to=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).