From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= Subject: [PATCH 2/2] cmd_clone: make sure repo is allocated on the heap and free it Date: Thu, 31 Mar 2011 17:10:42 +0200 Message-ID: <1301584242-3193-2-git-send-email-cmn@elego.de> References: <1301583996.11592.3.camel@bee.lab.cmartin.tk> <1301584242-3193-1-git-send-email-cmn@elego.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Junio C Hamano To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Thu Mar 31 17:10:54 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5JWP-0007uq-Fv for gcvg-git-2@lo.gmane.org; Thu, 31 Mar 2011 17:10:53 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758213Ab1CaPKp convert rfc822-to-quoted-printable (ORCPT ); Thu, 31 Mar 2011 11:10:45 -0400 Received: from kimmy.cmartin.tk ([91.121.65.165]:41316 "EHLO kimmy.cmartin.tk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758094Ab1CaPKn (ORCPT ); Thu, 31 Mar 2011 11:10:43 -0400 Received: from bee.lab.cmartin.tk (i59F7870A.versanet.de [89.247.135.10]) by kimmy.cmartin.tk (Postfix) with ESMTPA id 3CEEB4611E; Thu, 31 Mar 2011 17:10:33 +0200 (CEST) Received: (nullmailer pid 3235 invoked by uid 1000); Thu, 31 Mar 2011 15:10:42 -0000 X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1301584242-3193-1-git-send-email-cmn@elego.de> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Make sure that the buffer repo points to is in the heap and free it afterwards. Signed-off-by: Carlos Mart=C3=ADn Nieto --- builtin/clone.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/builtin/clone.c b/builtin/clone.c index fe0408c..697b1bf 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -415,7 +415,7 @@ int cmd_clone(int argc, const char **argv, const ch= ar *prefix) else if (!strchr(repo_name, ':')) die("repository '%s' does not exist", repo_name); else - repo =3D repo_name; + repo =3D xstrdup(repo_name); is_local =3D path && !is_bundle; if (is_local && option_depth) warning("--depth is ignored in local clones; use file:// instead."); @@ -667,6 +667,7 @@ int cmd_clone(int argc, const char **argv, const ch= ar *prefix) =20 free(dir); free(path); + free(repo); strbuf_release(&reflog_msg); strbuf_release(&branch_top); strbuf_release(&key); --=20 1.7.4.1