From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Alejandro=20R=2E=20Sede=C3=B1o?= Subject: [PATCH 2/2] git-svn: Cache results of running the executable "git config" Date: Fri, 1 Apr 2011 14:42:16 -0400 Message-ID: <1301683336-10832-3-git-send-email-asedeno@mit.edu> References: <1301683336-10832-1-git-send-email-asedeno@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: James Y Knight , =?UTF-8?q?Alejandro=20R=2E=20Sede=C3=B1o?= To: git@vger.kernel.org, Eric Wong X-From: git-owner@vger.kernel.org Fri Apr 01 20:50:03 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5jQ2-0001UW-OG for gcvg-git-2@lo.gmane.org; Fri, 01 Apr 2011 20:50:03 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758256Ab1DASt5 convert rfc822-to-quoted-printable (ORCPT ); Fri, 1 Apr 2011 14:49:57 -0400 Received: from mx1.itasoftware.com ([63.115.78.20]:56262 "EHLO mx1.itasoftware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757852Ab1DASt4 (ORCPT ); Fri, 1 Apr 2011 14:49:56 -0400 X-Greylist: delayed 435 seconds by postgrey-1.27 at vger.kernel.org; Fri, 01 Apr 2011 14:49:56 EDT Received: from ita4mta3.internal.itasoftware.com (ita4mta3.internal.itasoftware.com [10.4.52.159]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.itasoftware.com (Postfix) with ESMTP id 33FC2256D44; Fri, 1 Apr 2011 14:42:35 -0400 (EDT) Received: from asedeno.corp.itasoftware.com (lb1.dc4nat128.dc4.internal.itasoftware.com [10.4.199.128]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ita4mta3.internal.itasoftware.com (Postfix) with ESMTP id 135011C24058; Fri, 1 Apr 2011 14:42:35 -0400 (EDT) Received: from asedeno by asedeno.corp.itasoftware.com with local (Exim 4.74) (envelope-from ) id 1Q5jIp-0007Qw-0Q; Fri, 01 Apr 2011 14:42:35 -0400 X-Mailer: git-send-email 1.7.4.2.1.gd6f1f In-Reply-To: <1301683336-10832-1-git-send-email-asedeno@mit.edu> X-ITASoftware-MailScanner: Found to be clean X-ITASoftware-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1, required 3, ALL_TRUSTED -1.00) X-ITASoftware-MailScanner-From: asedeno@itasoftware.com X-Spam-Status: No Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: =46rom: James Y Knight Running programs is not cheap! Signed-off-by: Alejandro R. Sede=C3=B1o --- git-svn.perl | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/git-svn.perl b/git-svn.perl index aa41896..e47e04c 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -59,6 +59,7 @@ use File::Find; use Getopt::Long qw/:config gnu_getopt no_ignore_case auto_abbrev/; use IPC::Open3; use Git; +use Memoize; # core since 5.8.0, Jul 2002 =20 BEGIN { # import functions from Git into our packages, en masse @@ -72,6 +73,8 @@ BEGIN { *{"${package}::$_"} =3D \&{"Git::$_"}; } } + Memoize::memoize 'Git::config'; + Memoize::memoize 'Git::config_bool'; } =20 my ($SVN); @@ -3199,6 +3202,8 @@ sub has_no_changes { Memoize::unmemoize 'check_cherry_pick'; Memoize::unmemoize 'has_no_changes'; } + + Memoize::memoize 'Git::SVN::repos_root'; } =20 END { --=20 1.7.4.2.1.gd6f1f