From: Namhyung Kim <namhyung@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH v2 2/3] blame: honor core.abbrev
Date: Wed, 6 Apr 2011 11:20:51 +0900 [thread overview]
Message-ID: <1302056452-5387-2-git-send-email-namhyung@gmail.com> (raw)
In-Reply-To: <1302056452-5387-1-git-send-email-namhyung@gmail.com>
If user sets config.abbrev option, use it as if --abbrev was given.
This is the default value and user can override different abbrev
length by specifing --abbrev=N command line option.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
builtin/blame.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index 253b480..4639788 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -41,7 +41,7 @@ static int reverse;
static int blank_boundary;
static int incremental;
static int xdl_opts;
-static int abbrev = 8;
+static int abbrev = -1;
static enum date_mode blame_date_mode = DATE_ISO8601;
static size_t blame_date_width;
@@ -2347,6 +2347,11 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
parse_done:
argc = parse_options_end(&ctx);
+ if (abbrev == -1)
+ abbrev = default_abbrev;
+ /* one more abbrev length is needed for the boundary commit */
+ abbrev++;
+
if (revs_file && read_ancestry(revs_file))
die_errno("reading graft file '%s' failed", revs_file);
--
1.7.4
next prev parent reply other threads:[~2011-04-06 2:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 2:20 [PATCH v2 1/3] blame: add --abbrev command line option Namhyung Kim
2011-04-06 2:20 ` Namhyung Kim [this message]
2011-04-06 2:20 ` [PATCH v2 3/3] Documentation: add --abbrev option to the man page of git blame Namhyung Kim
2011-04-06 2:46 ` [PATCH v2 1/3] blame: add --abbrev command line option Thiago Farina
2011-04-06 3:18 ` Junio C Hamano
2011-04-06 11:06 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302056452-5387-2-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).