From: Joe Perches <joe@perches.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Stephen Boyd <bebarino@gmail.com>
Subject: Re: problem when using --cc-cmd
Date: Wed, 20 Apr 2011 12:48:20 -0700 [thread overview]
Message-ID: <1303328900.24766.29.camel@Joe-Laptop> (raw)
In-Reply-To: <BANLkTinfbF3xyfrdgfmgHQF7RHCHk8ardw@mail.gmail.com>
On Wed, 2011-04-20 at 12:45 -0300, Thiago Farina wrote:
> On Wed, Apr 20, 2011 at 12:03 AM, Joe Perches <joe@perches.com> wrote:
> > On Tue, 2011-04-19 at 16:52 -0500, Jonathan Nieder wrote:
> >> Thiago Farina wrote:
> >> > when I run:
> >> > $ git send-email --to linux-kernel@vger.kernel.org --cc-cmd
> >> > scripts/get_maintainer.pl foo
> >> > I'm getting some lines like:
> >> > Use of uninitialized value $cc in string eq at
> >> > /home/tfarina/libexec/git-core/git-send-email line 964.
> >> Yes, sounds like a bug. Cc-ing some send-email people for tips.
> > I haven't seen this.
> > What versions of ./scripts/get_maintainer.pl and git are
> > you using?
> $ scripts/get_maintainer.pl --version
> scripts/get_maintainer.pl 0.26
> $ git version
> git version 1.7.5.rc2.5.g60e19
To get this to work properly, the output of cc-cmd
(scripts/get_maintainer.pl) must be valid email addresses.
The git send-email --help for cc-cmd says:
--cc-cmd=<command>
Specify a command to execute once per patch file which should
generate patch file specific "Cc:" entries. Output of this command
must be single email address per line. Default is the value of
sendemail.cccmd configuration value.
You'll need to add "--norolestats" to the cc-cmd if
you use scripts/get_maintainer.pl.
$ git send-email --to linux-kernel@vger.kernel.org \
--cc-cmd "scripts/get_maintainer.pl --norolestats" foo
I suppose you could call it a defect that the
output of cc-cmd isn't screened for invalid
email addresses but I think it's not really a
problem.
next prev parent reply other threads:[~2011-04-20 19:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 22:32 problem when using --cc-cmd Thiago Farina
2011-04-19 21:52 ` Jonathan Nieder
2011-04-20 3:03 ` Joe Perches
2011-04-20 15:45 ` Thiago Farina
2011-04-20 19:48 ` Joe Perches [this message]
2011-04-20 21:50 ` [RFC PATCH] git-send-email: Validate recipient_cmd (to-cmd, cc-cmd) addresses Joe Perches
2011-04-20 22:29 ` Ævar Arnfjörð Bjarmason
2011-04-20 22:45 ` Joe Perches
2011-04-20 22:50 ` Ævar Arnfjörð Bjarmason
2011-04-20 23:01 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303328900.24766.29.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).