git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valentin Haenel <valentin.haenel@gmx.de>
To: git@vger.kernel.org
Cc: Eric Wong <normalperson@yhbt.net>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	Junio C Hamano <gitster@pobox.com>,
	Valentin Haenel <valentin.haenel@gmx.de>
Subject: [PATCH 0/2] Documentation fixes for git-svn.txt
Date: Fri, 22 Apr 2011 19:03:37 +0200	[thread overview]
Message-ID: <1303491819-9850-1-git-send-email-valentin.haenel@gmx.de> (raw)

Hi,

the command documentation for 'git svn fetch' lists the following two
options:

  --use-log-author

and

  --add-author-from

However, as the current description of both states, they are also
applicable to 'git svn' subcommands other than fetch. The first patch
moves them, the second patch applies some cosmetics.

My remaining question regarding the second option, '--add-author-from',
is about the subcommands which it is applicable to. The current
documentation states 'commit' and 'dcommit'. My feeling is that 'commit'
is a typo, since 'git svn' does not have a 'commit' subcommand. I had a
look at the code, and while I am not familiar with perl, it seems to me
that the three subcommands that use the option are 'commit-diff',
'set-tree' and 'dcommit'. But this is non-trivial -- feedback is
appreciated.

V-

Valentin Haenel (2):
  git-svn.txt: move option descriptions
  git-svn.txt: small typeface improvements

 Documentation/git-svn.txt |   23 ++++++++++++-----------
 1 files changed, 12 insertions(+), 11 deletions(-)

             reply	other threads:[~2011-04-22 17:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22 17:03 Valentin Haenel [this message]
2011-04-22 17:03 ` [PATCH 1/2] git-svn.txt: move option descriptions Valentin Haenel
2011-04-22 17:03 ` [PATCH 2/2] git-svn.txt: small typeface improvements Valentin Haenel
2011-04-25 21:06 ` [PATCH 0/2] Documentation fixes for git-svn.txt Eric Wong
2011-04-25 21:36   ` [PATCH] git-svn.txt: fix usage of --add-author-from Valentin Haenel
2011-04-25 21:58     ` Junio C Hamano
2011-04-26 11:34   ` [PATCHv2 0/2] Documentation fixes for git-svn.txt Valentin Haenel
2011-04-26 11:34   ` [PATCHv2 1/2] git-svn.txt: move option descriptions Valentin Haenel
2011-04-26 11:34   ` [PATCHv2 2/2] git-svn.txt: small typeface improvements Valentin Haenel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303491819-9850-1-git-send-email-valentin.haenel@gmx.de \
    --to=valentin.haenel@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).