From: Henrik Hautakoski <henrik@fiktivkod.org>
To: git@vger.kernel.org
Cc: Henrik Hautakoski <henrik@fiktivkod.org>
Subject: [PATCH] wt-status.c: Increase readability.
Date: Tue, 26 Apr 2011 09:08:33 +0200 [thread overview]
Message-ID: <1303801713-22639-1-git-send-email-henrik@fiktivkod.org> (raw)
Add braces to if/else statements to make the code more readable.
Signed-off-by: Henrik Hautakoski <henrik@fiktivkod.org>
---
wt-status.c | 26 ++++++++++++++------------
1 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/wt-status.c b/wt-status.c
index 9f4e0ba..9d8a0ea 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -448,9 +448,9 @@ static void wt_status_collect_changes_initial(struct wt_status *s)
if (ce_stage(ce)) {
d->index_status = DIFF_STATUS_UNMERGED;
d->stagemask |= (1 << (ce_stage(ce) - 1));
- }
- else
+ } else {
d->index_status = DIFF_STATUS_ADDED;
+ }
}
free_pathspec(&pathspec);
}
@@ -745,35 +745,37 @@ void wt_status_print(struct wt_status *s)
wt_status_print_other(s, &s->untracked, _("Untracked"), "add");
if (s->show_ignored_files)
wt_status_print_other(s, &s->ignored, _("Ignored"), "add -f");
- } else if (s->commitable)
+ } else if (s->commitable) {
status_printf_ln(s, GIT_COLOR_NORMAL, _("Untracked files not listed%s"),
advice_status_hints
? _(" (use -u option to show untracked files)") : "");
+ }
if (s->verbose)
wt_status_print_verbose(s);
if (!s->commitable) {
- if (s->amend)
+ if (s->amend) {
status_printf_ln(s, GIT_COLOR_NORMAL, _("No changes"));
- else if (s->nowarn)
+ } else if (s->nowarn) {
; /* nothing */
- else if (s->workdir_dirty)
+ } else if (s->workdir_dirty) {
printf(_("no changes added to commit%s\n"),
advice_status_hints
? _(" (use \"git add\" and/or \"git commit -a\")") : "");
- else if (s->untracked.nr)
+ } else if (s->untracked.nr) {
printf(_("nothing added to commit but untracked files present%s\n"),
advice_status_hints
? _(" (use \"git add\" to track)") : "");
- else if (s->is_initial)
+ } else if (s->is_initial) {
printf(_("nothing to commit%s\n"), advice_status_hints
? _(" (create/copy files and use \"git add\" to track)") : "");
- else if (!s->show_untracked_files)
+ } else if (!s->show_untracked_files) {
printf(_("nothing to commit%s\n"), advice_status_hints
? _(" (use -u to show untracked files)") : "");
- else
+ } else {
printf(_("nothing to commit%s\n"), advice_status_hints
? _(" (working directory clean)") : "");
+ }
}
}
@@ -878,9 +880,9 @@ static void wt_shortstatus_print_tracking(struct wt_status *s)
return;
branch_name = s->branch;
- if (!prefixcmp(branch_name, "refs/heads/"))
+ if (!prefixcmp(branch_name, "refs/heads/")) {
branch_name += 11;
- else if (!strcmp(branch_name, "HEAD")) {
+ } else if (!strcmp(branch_name, "HEAD")) {
branch_name = _("HEAD (no branch)");
branch_color_local = color(WT_STATUS_NOBRANCH, s);
}
--
1.7.3.4
next reply other threads:[~2011-04-26 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 7:08 Henrik Hautakoski [this message]
2011-04-26 7:50 ` [PATCH] wt-status.c: Increase readability Matthieu Moy
2011-04-26 9:13 ` Henrik Hautakoski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303801713-22639-1-git-send-email-henrik@fiktivkod.org \
--to=henrik@fiktivkod.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).