From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH] strbuf: allocate enough space when strbuf_setlen() is called first time
Date: Tue, 26 Apr 2011 19:24:20 +0700 [thread overview]
Message-ID: <1303820660-744-1-git-send-email-pclouds@gmail.com> (raw)
strbuf_grow(sb, 0) may allocate less than requested len and violate the
next assertion.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
strbuf.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/strbuf.h b/strbuf.h
index 07060ce..ab213da 100644
--- a/strbuf.h
+++ b/strbuf.h
@@ -34,7 +34,7 @@ extern void strbuf_grow(struct strbuf *, size_t);
static inline void strbuf_setlen(struct strbuf *sb, size_t len) {
if (!sb->alloc)
- strbuf_grow(sb, 0);
+ strbuf_grow(sb, len);
assert(len < sb->alloc);
sb->len = len;
sb->buf[len] = '\0';
--
1.7.4.74.g639db
next reply other threads:[~2011-04-26 12:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 12:24 Nguyễn Thái Ngọc Duy [this message]
2011-04-26 15:09 ` [PATCH] strbuf: allocate enough space when strbuf_setlen() is called first time Nguyen Thai Ngoc Duy
2011-04-26 15:25 ` Junio C Hamano
2011-04-26 15:32 ` Nguyen Thai Ngoc Duy
2011-04-26 16:54 ` René Scharfe
2011-04-26 17:18 ` Junio C Hamano
2011-04-26 21:26 ` René Scharfe
2011-04-26 21:51 ` Junio C Hamano
2011-04-27 17:24 ` René Scharfe
2011-04-28 16:57 ` Junio C Hamano
2011-04-27 0:12 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303820660-744-1-git-send-email-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).