git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elias Persson <delreich@takeit.se>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: git diff-index ignores color config
Date: Wed, 27 Apr 2011 09:20:46 +0200	[thread overview]
Message-ID: <1303888846.10130.7.camel@dhcp-141.kontor.deklomp.se> (raw)
In-Reply-To: <7voc3sewpg.fsf@alter.siamese.dyndns.org>

On Tue, 2011-04-26 at 10:42 -0700, Junio C Hamano wrote:
> Isn't that very much on purpose?  diff-{index,tree,files} plumbings should
> not be affected by UI related configuration variables.

Documentation indicates that color is configurable for it though.
I can't say if the issue is with the behavior or the documentation.

I can say I find the pre-commit verifying hook to be a lot more
useful when you can actually see the whitespace issues.

  reply	other threads:[~2011-04-27  7:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 15:04 git diff-index ignores color config Elias Persson
2011-04-26 17:42 ` Junio C Hamano
2011-04-27  7:20   ` Elias Persson [this message]
2011-04-27  7:38   ` [PATCH] config.txt,diff-options.txt: porcelain vs. plumbing for color.diff Michael J Gruber
2011-04-27  9:03     ` Jonathan Nieder
2011-04-27 16:39       ` Junio C Hamano
2011-04-27 18:30         ` Junio C Hamano
2011-04-27 22:12           ` Jonathan Nieder
2011-04-28  7:47             ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303888846.10130.7.camel@dhcp-141.kontor.deklomp.se \
    --to=delreich@takeit.se \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).