git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michał Kiedrowicz" <michal.kiedrowicz@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Martin Langhoff" <martin.langhoff@gmail.com>,
	"Michał Kiedrowicz" <michal.kiedrowicz@gmail.com>
Subject: [PATCH V2 0/5] Add PCRE support to git-grep
Date: Thu,  5 May 2011 00:00:16 +0200	[thread overview]
Message-ID: <1304546421-25439-1-git-send-email-michal.kiedrowicz@gmail.com> (raw)

This patch series attempts to add PCRE support to git-grep.

Changes from previous version:

* Now this series start from two patches which add the --line-number
  option to SYNOPSIS and bash completion; they can be treated
  separatedly from this series

* All patches have improved descriptions

* All patches have Signed-off-by

* libpcre specific code has been moved to a separate subsection to
  reduce number of #ifdefs; this addresses comments from Junio

* I noticed that even though I call pcre_study(), I didn't use its
  result in pcre_exec(); now this is fixed; this should improve
  git-grep --perl-regexp performance

* --perl-regexp has been added to bash-completion

* Added last patch which adds checks for libpcre to configure

* I repeated `make test` with and without pcre few more times and I
  cannot reproduce results from previous runs; possibly they were
  altered by current system load or cold cache. Now the difference
  is just few seconds. However, I'm still not convinced to link
  libgit.a with libpcre.

Michał Kiedrowicz (5):
  Documentation: Add --line-number to git-grep synopsis
  contrib/completion: --line-number to git grep
  grep: Put calls to fixmatch() and regmatch() into patmatch()
  git-grep: Learn PCRE
  configure: Check for libpcre

 Documentation/git-grep.txt             |    8 ++-
 Makefile                               |   16 +++++
 builtin/grep.c                         |    2 +
 config.mak.in                          |    1 +
 configure.ac                           |   26 ++++++++
 contrib/completion/git-completion.bash |    3 +-
 grep.c                                 |  100 +++++++++++++++++++++++++++++---
 grep.h                                 |    9 +++
 8 files changed, 154 insertions(+), 11 deletions(-)

-- 
1.7.3.4

             reply	other threads:[~2011-05-04 22:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04 22:00 Michał Kiedrowicz [this message]
2011-05-04 22:00 ` [PATCH V2 1/5] Documentation: Add --line-number to git-grep synopsis Michał Kiedrowicz
2011-05-04 22:00 ` [PATCH V2 2/5] contrib/completion: --line-number to git grep Michał Kiedrowicz
2011-05-04 22:00 ` [PATCH V2 3/5] grep: Put calls to fixmatch() and regmatch() into patmatch() Michał Kiedrowicz
2011-05-04 22:00 ` [PATCH V2 4/5] git-grep: Learn PCRE Michał Kiedrowicz
2011-05-05  1:09   ` Junio C Hamano
2011-05-05  5:47     ` Bert Wesarg
2011-05-05 16:55       ` Junio C Hamano
2011-05-05  6:19   ` Johannes Sixt
2011-05-05  7:41     ` Michal Kiedrowicz
2011-05-05  7:49       ` Johannes Sixt
2011-05-05  8:38         ` Michal Kiedrowicz
2011-05-05  6:28   ` Johannes Sixt
2011-05-05  7:43     ` Michal Kiedrowicz
2011-05-05  7:43   ` Alex Riesen
2011-05-04 22:00 ` [PATCH V2 5/5] configure: Check for libpcre Michał Kiedrowicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304546421-25439-1-git-send-email-michal.kiedrowicz@gmail.com \
    --to=michal.kiedrowicz@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=martin.langhoff@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).