git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: conrad.irwin@gmail.com
To: git@vger.kernel.org
Cc: Conrad Irwin <conrad.irwin@gmail.com>
Subject: [PATCH v3 2/3] Allow git commit --interactive with paths
Date: Fri,  6 May 2011 23:00:00 -0700	[thread overview]
Message-ID: <1304748001-17982-3-git-send-email-conrad.irwin@gmail.com> (raw)
In-Reply-To: <1304748001-17982-1-git-send-email-conrad.irwin@gmail.com>

From: Conrad Irwin <conrad.irwin@gmail.com>

Make git commit --interactive feel more like git add --interactive by
allowing the user to restrict the list of files they have to deal with.

Signed-off-by: Conrad Irwin <conrad.irwin@gmail.com>
---
 builtin/commit.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/builtin/commit.c b/builtin/commit.c
index 636aea6..7707af8 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1084,8 +1084,6 @@ static int parse_and_validate_options(int argc, const char *argv[],
 
 	if (all && argc > 0)
 		die(_("Paths with -a does not make sense."));
-	else if (interactive && argc > 0)
-		die(_("Paths with --interactive does not make sense."));
 
 	if (null_termination && status_format == STATUS_FORMAT_LONG)
 		status_format = STATUS_FORMAT_PORCELAIN;
-- 
1.7.5.188.g4817

  parent reply	other threads:[~2011-05-07  6:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-07  5:59 [PATCH v3 0/3] Git commit --patch (again) conrad.irwin
2011-05-07  5:59 ` [PATCH v3 1/3] Use a temporary index for git commit --interactive conrad.irwin
2011-05-07  6:00 ` conrad.irwin [this message]
2011-05-07  6:00 ` [PATCH v3 3/3] Add support for -p/--patch to git-commit conrad.irwin
2011-05-07 10:46   ` Valentin Haenel
2011-05-07 17:55     ` Conrad Irwin
2011-05-07 17:58       ` [PATCH v4 " Conrad Irwin
2011-05-08 19:27         ` Junio C Hamano
2011-05-07 17:59       ` [PATCH] Add commit to list of config.singlekey commands Conrad Irwin
2011-05-07  9:49 ` [PATCH v3 0/3] Git commit --patch (again) Sverre Rabbelier
2011-05-09 14:44 ` Jeff King
2011-05-09 16:53   ` Junio C Hamano
2011-05-09 22:08     ` Jeff King
2011-05-09 23:53       ` Junio C Hamano
2011-05-09 23:56         ` Junio C Hamano
2011-05-10 20:01           ` Jeff King
2011-05-10 19:56         ` Jeff King
2011-05-10  6:42   ` Conrad Irwin
2011-05-10 19:12     ` [PATCH] Test atomic git-commit --interactive Conrad Irwin
2011-05-10 19:43       ` Jeff King
2011-05-10 21:01         ` Conrad Irwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304748001-17982-3-git-send-email-conrad.irwin@gmail.com \
    --to=conrad.irwin@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).