[PATCH 0/4] convert.c clean-up

[Junio C Hamano <gitster@pobox.com>]

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

> Instead we could detect if convert-from/to-git is unnecessary and
> stream big blobs based on core.bigFileThresold. The below patch may
> help.

Yeah, I think that would probably make more sense. If a file is small
enough, it is more sensible to send it to a loose object just like any
other files. We do not want to invite users to make a mistake of marking
it as bigdata and send it straight to a packfile. Having one less knob to
tweak is always a good thing to do.

However, while reviewing your patch, I noticed that convert.c was littered
with misnamed types, variables and functions to the point to make it
almost unreadble as the result of its evolution.  I originally wrote this
series so that I can add "bigdata" sensibly, and it turns out that there
is no benefit to do so for now, but the clean-up by itself would be worth
it.

So there...

Junio C Hamano (4):
  convert: rename the "eol" global variable to "core_eol"
  convert: give saner names to crlf/eol variables, types and functions
  convert: make it safer to add conversion attributes
  convert: make it harder to screw up adding a conversion attribute

 cache.h       |    2 +-
 config.c      |   12 ++--
 convert.c     |  158 +++++++++++++++++++++++++++-----------------------------
 environment.c |    2 +-
 4 files changed, 84 insertions(+), 90 deletions(-)

-- 
1.7.5.1.288.g93ebc