git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luke Diamand <luke@diamand.org>
To: git@vger.kernel.org
Cc: Pete Wyckoff <pw@padd.com>, Luke Diamand <luke@diamand.org>
Subject: [PATCHv1] git-p4: test harness directory handling tidyup
Date: Thu, 12 May 2011 06:14:58 +0100	[thread overview]
Message-ID: <1305177299-27130-1-git-send-email-luke@diamand.org> (raw)

Junio pointed out that the git-p4 test harness (t9800-git-p4.sh) has
tests that 'cd' into a directory, do stuff, and then cd back out. If
the tests fail partway through then the process is left in the wrong
directory for the next test.

This patch changes it to use the "(cd dir && do_test)" pattern instead.

Luke Diamand (1):
  git-p4: test harness directory changing tidyup

 t/t9800-git-p4.sh |   37 ++++++++++++++++++++++---------------
 1 files changed, 22 insertions(+), 15 deletions(-)

             reply	other threads:[~2011-05-12  5:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-12  5:14 Luke Diamand [this message]
2011-05-12  5:14 ` [PATCHv1] git-p4: test harness directory handling tidyup Luke Diamand
2011-05-12 11:29   ` Pete Wyckoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305177299-27130-1-git-send-email-luke@diamand.org \
    --to=luke@diamand.org \
    --cc=git@vger.kernel.org \
    --cc=pw@padd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).