From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Daniel Barkalow <barkalow@iabervon.org>,
Christian Couder <christian.couder@gmail.com>
Subject: [PATCH 08/10] revert: Introduce HEAD, TODO files to persist state, plan
Date: Wed, 25 May 2011 14:17:03 +0000 [thread overview]
Message-ID: <1306333025-29893-9-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1306333025-29893-1-git-send-email-artagnon@gmail.com>
Ever since v1.7.2-rc1~4^2~7 (revert: allow cherry-picking more than
one commit, 2010-06-02), a single invocation of "git cherry-pick" or
"git revert" can perform picks of several individual commits. To
allow "git cherry-pick --abort" to cancel and "git cherry-pick
--continue" to resume the entire command, we will need to store some
information about the state and the plan at the beginning. Introduce
a HEAD file to store this state, and TODO file to store the plan.
Helped-by: Christian Couder <chriscool@tuxfamily.org>
Helped-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
builtin/revert.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++--
1 files changed, 73 insertions(+), 3 deletions(-)
diff --git a/builtin/revert.c b/builtin/revert.c
index d21af96..4741252 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -13,6 +13,7 @@
#include "rerere.h"
#include "merge-recursive.h"
#include "refs.h"
+#include "dir.h"
/*
* This implements the builtins revert and cherry-pick.
@@ -25,6 +26,12 @@
* Copyright (c) 2005 Junio C Hamano
*/
+#define SEQ_DIR "sequencer"
+
+#define SEQ_PATH git_path(SEQ_DIR)
+#define HEAD_FILE git_path(SEQ_DIR "/head")
+#define TODO_FILE git_path(SEQ_DIR "/todo")
+
static const char * const revert_usage[] = {
"git revert [options] <commit-ish>",
NULL
@@ -584,22 +591,85 @@ static void read_and_refresh_cache(const char *me, struct replay_opts *opts)
rollback_lock_file(&index_lock);
}
+static void format_todo(struct strbuf *buf, struct commit_list *list,
+ struct replay_opts *opts)
+{
+ struct commit_list *cur = NULL;
+ struct commit_message msg = { NULL, NULL, NULL, NULL, NULL };
+ const char *sha1_abbrev = NULL;
+ const char *action;
+
+ action = (opts->action == REVERT ? "revert" : "pick");
+ for (cur = list; cur; cur = cur->next) {
+ sha1_abbrev = find_unique_abbrev(cur->item->object.sha1, DEFAULT_ABBREV);
+ if (get_message(sha1_abbrev, cur->item->buffer, &msg))
+ die(_("Cannot get commit message for %s"), sha1_abbrev);
+ strbuf_addf(buf, "%s %s %s\n", action, sha1_abbrev, msg.subject);
+ }
+}
+
+static void persist_head(unsigned char *head)
+{
+ struct strbuf buf = STRBUF_INIT;
+ struct lock_file head_lock;
+ int fd;
+
+ if (file_exists(SEQ_PATH)) {
+ if (!is_directory(SEQ_PATH) && remove_path(SEQ_PATH) < 0) {
+ strbuf_release(&buf);
+ die(_("Could not remove %s"), SEQ_PATH);
+ }
+ }
+ if (!file_exists(SEQ_PATH) && mkdir(SEQ_PATH, 0777) < 0) {
+ strbuf_release(&buf);
+ die_errno(_("Could not create sequencer directory '%s'."), SEQ_PATH);
+ }
+
+ fd = hold_lock_file_for_update(&head_lock, HEAD_FILE, LOCK_DIE_ON_ERROR);
+ strbuf_addf(&buf, "%s", head);
+ if (write_in_full(fd, buf.buf, buf.len) < 0)
+ die_errno(_("Could not write to %s."), HEAD_FILE);
+ if (commit_lock_file(&head_lock) < 0)
+ die(_("Error wrapping up %s"), HEAD_FILE);
+}
+
+static void persist_todo(struct commit_list *todo_list, struct replay_opts *opts)
+{
+ struct strbuf buf = STRBUF_INIT;
+ struct lock_file todo_lock;
+ int fd;
+
+ fd = hold_lock_file_for_update(&todo_lock, TODO_FILE, LOCK_DIE_ON_ERROR);
+ format_todo(&buf, todo_list, opts);
+ if (write_in_full(fd, buf.buf, buf.len) < 0)
+ die_errno(_("Could not write to %s."), TODO_FILE);
+ if (commit_lock_file(&todo_lock) < 0)
+ die(_("Error wrapping up %s"), TODO_FILE);
+}
+
static int pick_commits(struct replay_opts *opts)
{
struct rev_info revs;
struct commit *commit;
+ unsigned char head[20];
setenv(GIT_REFLOG_ACTION, me, 0);
- read_and_refresh_cache(me, opts);
+ if (get_sha1("HEAD", head))
+ return error(_("You do not have a valid HEAD"));
+
+ read_and_refresh_cache(me, opts);
prepare_revs(&revs, opts);
+ persist_head(head);
while ((commit = get_revision(&revs))) {
int res = do_pick_commit(commit, opts);
- if (res)
+ if (res) {
+ commit_list_insert(commit, &revs.commits);
+ persist_todo(revs.commits, opts);
return res;
+ }
}
-
return 0;
}
--
1.7.5.GIT
next prev parent reply other threads:[~2011-05-25 14:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 14:16 [PATCH v3 00/10] Sequencer Foundations Ramkumar Ramachandra
2011-05-25 14:16 ` [PATCH 01/10] advice: Introduce error_resolve_conflict Ramkumar Ramachandra
2011-05-25 14:16 ` [PATCH 02/10] revert: Propogate errors upwards from do_pick_commit Ramkumar Ramachandra
2011-05-25 22:44 ` Junio C Hamano
2011-05-26 9:34 ` Ramkumar Ramachandra
2011-05-25 14:16 ` [PATCH 03/10] revert: Eliminate global "commit" variable Ramkumar Ramachandra
2011-05-25 23:10 ` Junio C Hamano
2011-05-25 14:16 ` [PATCH 04/10] revert: Rename no_replay to record_origin Ramkumar Ramachandra
2011-05-25 14:17 ` [PATCH 05/10] revert: Introduce struct to keep command-line options Ramkumar Ramachandra
2011-05-25 14:17 ` [PATCH 06/10] revert: Separate cmdline parsing from functional code Ramkumar Ramachandra
2011-05-25 14:17 ` [PATCH 07/10] revert: Catch incompatible command-line options early Ramkumar Ramachandra
2011-05-25 14:17 ` Ramkumar Ramachandra [this message]
2011-05-25 14:17 ` [PATCH 09/10] revert: Implement parsing --continue, --abort and --skip Ramkumar Ramachandra
2011-05-25 14:17 ` [PATCH 10/10] revert: Implement --abort processing Ramkumar Ramachandra
2011-05-25 23:15 ` [PATCH v3 00/10] Sequencer Foundations Junio C Hamano
2011-05-26 15:53 ` [PATCH v4 " Ramkumar Ramachandra
2011-05-26 15:53 ` [PATCH 01/10] advice: Introduce error_resolve_conflict Ramkumar Ramachandra
2011-05-26 15:53 ` [PATCH 02/10] revert: Propogate errors upwards from do_pick_commit Ramkumar Ramachandra
2011-05-26 15:53 ` [PATCH 03/10] revert: Eliminate global "commit" variable Ramkumar Ramachandra
2011-05-26 15:53 ` [PATCH 04/10] revert: Rename no_replay to record_origin Ramkumar Ramachandra
2011-05-26 15:53 ` [PATCH 05/10] revert: Introduce struct to keep command-line options Ramkumar Ramachandra
2011-05-26 15:53 ` [PATCH 06/10] revert: Separate cmdline parsing from functional code Ramkumar Ramachandra
2011-05-26 15:53 ` [PATCH 07/10] revert: Catch incompatible command-line options early Ramkumar Ramachandra
2011-05-26 15:53 ` [PATCH 08/10] revert: Introduce HEAD, TODO files to persist state, plan Ramkumar Ramachandra
2011-05-26 16:11 ` Jonathan Nieder
2011-05-26 16:26 ` Ramkumar Ramachandra
2011-05-26 17:05 ` Ramkumar Ramachandra
2011-05-26 21:03 ` Junio C Hamano
2011-06-01 15:28 ` Ramkumar Ramachandra
2011-06-01 19:31 ` Jonathan Nieder
2011-06-02 12:53 ` Ramkumar Ramachandra
2011-06-02 14:29 ` Jeff King
2011-06-08 13:14 ` Ramkumar Ramachandra
2011-05-26 15:53 ` [PATCH 09/10] revert: Implement parsing --continue, --abort and --skip Ramkumar Ramachandra
2011-05-26 15:53 ` [PATCH 10/10] revert: Implement --abort processing Ramkumar Ramachandra
2011-05-26 19:13 ` [PATCH v4 00/10] Sequencer Foundations Junio C Hamano
2011-05-27 7:22 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306333025-29893-9-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=barkalow@iabervon.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).