From: Felipe Balbi <balbi@ti.com>
To: git@vger.kernel.org
Cc: Felipe Balbi <balbi@ti.com>
Subject: [PATCH] commit: use generic sha1_pos()
Date: Wed, 1 Jun 2011 16:20:16 +0300 [thread overview]
Message-ID: <1306934416-4205-1-git-send-email-balbi@ti.com> (raw)
instead of reimplementing the binary search,
use the generic sha1_pos().
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
commit.c | 25 ++++++++++---------------
1 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/commit.c b/commit.c
index ac337c7..ee8788f 100644
--- a/commit.c
+++ b/commit.c
@@ -6,6 +6,7 @@
#include "diff.h"
#include "revision.h"
#include "notes.h"
+#include "sha1-lookup.h"
int save_commit_buffer = 1;
@@ -92,23 +93,17 @@ static unsigned long parse_commit_date(const char *buf, const char *tail)
static struct commit_graft **commit_graft;
static int commit_graft_alloc, commit_graft_nr;
+static const unsigned char *commit_graft_access(size_t index, void *table)
+{
+ struct commit_graft **graft = table;
+
+ return graft[index]->sha1;
+}
+
static int commit_graft_pos(const unsigned char *sha1)
{
- int lo, hi;
- lo = 0;
- hi = commit_graft_nr;
- while (lo < hi) {
- int mi = (lo + hi) / 2;
- struct commit_graft *graft = commit_graft[mi];
- int cmp = hashcmp(sha1, graft->sha1);
- if (!cmp)
- return mi;
- if (cmp < 0)
- hi = mi;
- else
- lo = mi + 1;
- }
- return -lo - 1;
+ return sha1_pos(sha1, commit_graft, commit_graft_nr,
+ commit_graft_access);
}
int register_commit_graft(struct commit_graft *graft, int ignore_dups)
--
1.7.5.1.300.gc565c
reply other threads:[~2011-06-01 13:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306934416-4205-1-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).