git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] commit: use generic sha1_pos()
@ 2011-06-01 13:20 Felipe Balbi
  0 siblings, 0 replies; only message in thread
From: Felipe Balbi @ 2011-06-01 13:20 UTC (permalink / raw)
  To: git; +Cc: Felipe Balbi

instead of reimplementing the binary search,
use the generic sha1_pos().

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 commit.c |   25 ++++++++++---------------
 1 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/commit.c b/commit.c
index ac337c7..ee8788f 100644
--- a/commit.c
+++ b/commit.c
@@ -6,6 +6,7 @@
 #include "diff.h"
 #include "revision.h"
 #include "notes.h"
+#include "sha1-lookup.h"
 
 int save_commit_buffer = 1;
 
@@ -92,23 +93,17 @@ static unsigned long parse_commit_date(const char *buf, const char *tail)
 static struct commit_graft **commit_graft;
 static int commit_graft_alloc, commit_graft_nr;
 
+static const unsigned char *commit_graft_access(size_t index, void *table)
+{
+	struct commit_graft **graft = table;
+
+	return graft[index]->sha1;
+}
+
 static int commit_graft_pos(const unsigned char *sha1)
 {
-	int lo, hi;
-	lo = 0;
-	hi = commit_graft_nr;
-	while (lo < hi) {
-		int mi = (lo + hi) / 2;
-		struct commit_graft *graft = commit_graft[mi];
-		int cmp = hashcmp(sha1, graft->sha1);
-		if (!cmp)
-			return mi;
-		if (cmp < 0)
-			hi = mi;
-		else
-			lo = mi + 1;
-	}
-	return -lo - 1;
+	return sha1_pos(sha1, commit_graft, commit_graft_nr,
+			commit_graft_access);
 }
 
 int register_commit_graft(struct commit_graft *graft, int ignore_dups)
-- 
1.7.5.1.300.gc565c

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-06-01 13:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-01 13:20 [PATCH] commit: use generic sha1_pos() Felipe Balbi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).