From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tay Ray Chuan Subject: [PATCH v3 1/4] xdiff/xprepare: use memset() Date: Thu, 7 Jul 2011 12:23:55 +0800 Message-ID: <1310012638-3668-2-git-send-email-rctay89@gmail.com> References: <1309970337-6016-1-git-send-email-rctay89@gmail.com> <1310012638-3668-1-git-send-email-rctay89@gmail.com> Cc: "Junio C Hamano" , "Shawn O. Pearce" To: "Git Mailing List" X-From: git-owner@vger.kernel.org Thu Jul 07 06:24:25 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qeg8X-0008ID-0o for gcvg-git-2@lo.gmane.org; Thu, 07 Jul 2011 06:24:25 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198Ab1GGEYU (ORCPT ); Thu, 7 Jul 2011 00:24:20 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:52104 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794Ab1GGEYS (ORCPT ); Thu, 7 Jul 2011 00:24:18 -0400 Received: by iyb12 with SMTP id 12so535294iyb.19 for ; Wed, 06 Jul 2011 21:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=+sa0LspLJ4KhnfowEugzb0K7qLkJw7oRtWq4AcvLrgU=; b=JZZbhqQUYs/FMgAJsc2B7H0HTAhlIFbb21MH7tH/M0Andr9x6ricq4HlffvVmWHsde dMy4aFkkR6Tfa51TsO8UU0GwA/OcNBa4tFZmKqGFTY+F20GAw/sJynILuTZ4XDG/JlGo venAFQoLYNRBZNis1ufU9rb/sxxI5cRT6E/ZQ= Received: by 10.231.16.3 with SMTP id m3mr298963iba.195.1310012657356; Wed, 06 Jul 2011 21:24:17 -0700 (PDT) Received: from localhost (cm119.beta238.maxonline.com.sg [116.86.238.119]) by mx.google.com with ESMTPS id v16sm5246956ibe.51.2011.07.06.21.24.14 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Jul 2011 21:24:16 -0700 (PDT) X-Mailer: git-send-email 1.7.4.msysgit.0 In-Reply-To: <1310012638-3668-1-git-send-email-rctay89@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Use memset() instead of a for loop to initialize. This could give a performance advantage. Signed-off-by: Tay Ray Chuan --- xdiff/xprepare.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/xdiff/xprepare.c b/xdiff/xprepare.c index 1689085..783631a 100644 --- a/xdiff/xprepare.c +++ b/xdiff/xprepare.c @@ -64,8 +64,6 @@ static int xdl_optimize_ctxs(xdfile_t *xdf1, xdfile_t *xdf2); static int xdl_init_classifier(xdlclassifier_t *cf, long size, long flags) { - long i; - cf->flags = flags; cf->hbits = xdl_hashbits((unsigned int) size); @@ -80,8 +78,7 @@ static int xdl_init_classifier(xdlclassifier_t *cf, long size, long flags) { xdl_cha_free(&cf->ncha); return -1; } - for (i = 0; i < cf->hsize; i++) - cf->rchash[i] = NULL; + memset(cf->rchash, 0, cf->hsize * sizeof(xdlclass_t *)); cf->count = 0; @@ -136,7 +133,7 @@ static int xdl_classify_record(xdlclassifier_t *cf, xrecord_t **rhash, unsigned static int xdl_prepare_ctx(mmfile_t *mf, long narec, xpparam_t const *xpp, xdlclassifier_t *cf, xdfile_t *xdf) { unsigned int hbits; - long i, nrec, hsize, bsize; + long nrec, hsize, bsize; unsigned long hav; char const *blk, *cur, *top, *prev; xrecord_t *crec; @@ -164,8 +161,7 @@ static int xdl_prepare_ctx(mmfile_t *mf, long narec, xpparam_t const *xpp, xdl_cha_free(&xdf->rcha); return -1; } - for (i = 0; i < hsize; i++) - rhash[i] = NULL; + memset(rhash, 0, hsize * sizeof(xrecord_t *)); nrec = 0; if ((cur = blk = xdl_mmfile_first(mf, &bsize)) != NULL) { -- 1.7.3.4.676.gf08cd.dirty