git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Erik Faye-Lund <kusmabite@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH/RFC 0/3] port upload-archive to windows
Date: Thu,  7 Jul 2011 13:43:06 +0200	[thread overview]
Message-ID: <1310038989-5724-1-git-send-email-kusmabite@gmail.com> (raw)

Upload-archive, while compiled and installed on Windows, never
worked due to it's dependence on fork. This is a patch-series to
remedy that.

While doing this, I found a bug in gnulib's poll-emulation where
it could return 0 even when timeout was -1. This is neither
something POSIX allows, nor something our code is expecting.

So I've submitted an upstream patch for gnulib and upgraded our
copy.

Erik Faye-Lund (3):
  compat/win32/sys/poll.c: upgrade from upstream
  mingw: fix compilation of poll-emulation
  upload-archive: use start_command instead of fork

 builtin/upload-archive.c |   62 ++++++++++++----------------------------------
 compat/mingw.h           |    2 -
 compat/win32/sys/poll.c  |   17 +++++++++---
 3 files changed, 28 insertions(+), 53 deletions(-)

-- 
1.7.6.135.ge14e3f

             reply	other threads:[~2011-07-07 11:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 11:43 Erik Faye-Lund [this message]
2011-07-07 11:43 ` [PATCH/RFC 1/3] compat/win32/sys/poll.c: upgrade from upstream Erik Faye-Lund
2011-07-07 11:43 ` [PATCH/RFC 2/3] mingw: fix compilation of poll-emulation Erik Faye-Lund
2011-07-07 11:43 ` [PATCH/RFC 3/3] upload-archive: use start_command instead of fork Erik Faye-Lund
2011-07-07 18:21   ` Johannes Sixt
2011-07-07 18:39     ` Erik Faye-Lund
2011-07-07 19:15   ` Jeff King
2011-07-07 22:25     ` Erik Faye-Lund
2011-07-07 22:27       ` Jeff King
2011-07-07 22:37         ` Erik Faye-Lund
2011-07-07 22:44           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310038989-5724-1-git-send-email-kusmabite@gmail.com \
    --to=kusmabite@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).