From: Marc Branchaud <marcnarc@xiplink.com>
To: git@vger.kernel.org
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
Jakub Narebski <jnareb@gmail.com>
Subject: [RFC/PATCH] Changed gitweb.remote_heads config key name to gitweb.remoteHeads.
Date: Thu, 7 Jul 2011 14:02:19 -0400 [thread overview]
Message-ID: <1310061739-4441-1-git-send-email-marcnarc@xiplink.com> (raw)
Git doesn't accept config key names with underscore characters.
Signed-off-by: Marc Branchaud <marcnarc@xiplink.com>
---
Came across this today. The patch is RFC because I have not verified
if it's complete or if gitweb even respects the setting.
gitweb/gitweb.perl | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 81dacf2..edbb080 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -524,9 +524,9 @@ our %feature = (
# $feature{'remote_heads'}{'default'} = [1];
# To have project specific config enable override in $GITWEB_CONFIG
# $feature{'remote_heads'}{'override'} = 1;
- # and in project config gitweb.remote_heads = 0|1;
+ # and in project config gitweb.remoteHeads = 0|1;
'remote_heads' => {
- 'sub' => sub { feature_bool('remote_heads', @_) },
+ 'sub' => sub { feature_bool('remoteHeads', @_) },
'override' => 0,
'default' => [0]},
);
--
1.7.6
next reply other threads:[~2011-07-07 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 18:02 Marc Branchaud [this message]
2011-07-07 18:56 ` [RFC/PATCH] Changed gitweb.remote_heads config key name to gitweb.remoteHeads Jakub Narebski
2011-07-07 20:36 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310061739-4441-1-git-send-email-marcnarc@xiplink.com \
--to=marcnarc@xiplink.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).