From: Sverre Rabbelier <srabbelier@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>, Jeff King <peff@peff.net>,
Git List <git@vger.kernel.org>,
Daniel Barkalow <barkalow@iabervon.org>,
Ramkumar
Cc: Sverre Rabbelier <srabbelier@gmail.com>
Subject: [PATCH 4/5] fast-export: do not export negative refs
Date: Sun, 24 Jul 2011 16:21:21 +0200 [thread overview]
Message-ID: <1311517282-24831-5-git-send-email-srabbelier@gmail.com> (raw)
In-Reply-To: <1311517282-24831-1-git-send-email-srabbelier@gmail.com>
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
When calling `git fast-export master..next` we want to export
refs/heads/next, but not refs/heads/master.
Currently this is not a problem, because negative refs' commits
are never shown. In the next commit this will be changed in order
to make sure that 'master..master' does export master. I.e. even
refs whose commits are not shown are exported.
Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
---
We noticed this while trying to come up with a test case for the
bug we found.
builtin/fast-export.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin/fast-export.c b/builtin/fast-export.c
index 92743c8..628eab0 100644
--- a/builtin/fast-export.c
+++ b/builtin/fast-export.c
@@ -467,7 +467,7 @@ static void get_tags_and_duplicates(struct object_array *pending,
struct commit *commit = commit;
char *full_name;
- if (dwim_ref(e->name, strlen(e->name), sha1, &full_name) != 1)
+ if ((e->flags & UNINTERESTING) || dwim_ref(e->name, strlen(e->name), sha1, &full_name) != 1)
continue;
switch (e->item->type) {
--
1.7.6.385.g91185.dirty
next prev parent reply other threads:[~2011-07-24 14:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-24 14:21 [PATCH 0/5] fast-export: prepare for remote helpers awesomeness Sverre Rabbelier
2011-07-24 14:21 ` [PATCH 1/5] t9350: point out that refs are not updated correctly Sverre Rabbelier
2011-07-24 14:21 ` [PATCH 2/5] fast-export: do not refer to non-existing marks Sverre Rabbelier
2011-07-24 14:21 ` [PATCH 3/5] setup_revisions: remember whether a ref was positive or not Sverre Rabbelier
2011-07-24 19:23 ` Junio C Hamano
2011-07-24 23:17 ` Junio C Hamano
2011-08-03 13:52 ` Sverre Rabbelier
2011-08-03 18:12 ` Junio C Hamano
2011-08-08 16:22 ` Johannes Schindelin
2011-08-08 17:47 ` Junio C Hamano
2011-08-08 21:27 ` Sverre Rabbelier
2011-08-08 22:07 ` Junio C Hamano
2011-08-08 22:30 ` Sverre Rabbelier
2011-08-08 22:36 ` Junio C Hamano
2011-08-08 22:38 ` Sverre Rabbelier
2011-08-08 22:46 ` Junio C Hamano
2011-08-08 22:48 ` Sverre Rabbelier
2011-08-08 23:17 ` Junio C Hamano
2011-08-08 23:25 ` Sverre Rabbelier
2011-08-08 23:39 ` Junio C Hamano
2011-08-08 22:24 ` Junio C Hamano
2011-08-08 22:28 ` Sverre Rabbelier
2011-08-08 22:56 ` Junio C Hamano
2011-08-08 23:04 ` Sverre Rabbelier
2011-07-26 15:16 ` Johannes Schindelin
2011-07-24 14:21 ` Sverre Rabbelier [this message]
2011-07-24 19:07 ` [PATCH 4/5] fast-export: do not export negative refs Junio C Hamano
2011-07-26 15:11 ` Johannes Schindelin
2011-07-24 14:21 ` [PATCH 5/5] setup_revisions: remember whether a ref was positive or not Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311517282-24831-5-git-send-email-srabbelier@gmail.com \
--to=srabbelier@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).