From: Jon Seymour <jon.seymour@gmail.com>
To: git@vger.kernel.org
Cc: Jens.Lehmann@web.de, gitster@pobox.com,
Jon Seymour <jon.seymour@gmail.com>
Subject: [PATCH v3 0/2] ls-tree: exit with non-zero status on error
Date: Mon, 25 Jul 2011 00:59:12 +1000 [thread overview]
Message-ID: <1311519554-16587-1-git-send-email-jon.seymour@gmail.com> (raw)
While working with a damaged repository, I noticed that git ls-tree was reporting an error
even though it set a zero exit code.
This patch uses the return code from read_tree_recursive instead.
| v2: Amended test per Jens Lehmann's suggestion.
| v3: Generalize name of test script (in response to Junio's comment).
| Removed unnecessary local variable, per Jens' comment.
Jon Seymour (2):
Add a test to check that git ls-tree sets non-zero exit code on
error.
Ensure git ls-tree exits with a non-zero exit code if
read_tree_recursive fails.
builtin/ls-tree.c | 6 +++---
t/t3103-ls-tree-misc.sh | 19 +++++++++++++++++++
2 files changed, 22 insertions(+), 3 deletions(-)
create mode 100755 t/t3103-ls-tree-missing-tree.sh
--
1.7.6.347.g6a5a9c
next reply other threads:[~2011-07-24 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-24 14:59 Jon Seymour [this message]
2011-07-24 14:59 ` [PATCH v3 1/2] Add a test to check that git ls-tree sets non-zero exit code on error Jon Seymour
2011-07-24 14:59 ` [PATCH v3 2/2] Ensure git ls-tree exits with a non-zero exit code if read_tree_recursive fails Jon Seymour
2011-07-25 1:31 ` Nguyen Thai Ngoc Duy
2011-07-25 8:45 ` Jon Seymour
2011-07-25 12:58 ` Nguyen Thai Ngoc Duy
2011-07-25 16:17 ` Andreas Schwab
2011-07-25 16:46 ` Jens Lehmann
2011-07-25 17:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311519554-16587-1-git-send-email-jon.seymour@gmail.com \
--to=jon.seymour@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).