From: Michael Haggerty <mhagger@alum.mit.edu>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH 00/19] Add --all option to git-check-attr
Date: Tue, 26 Jul 2011 16:12:43 +0200 [thread overview]
Message-ID: <1311689582-3116-1-git-send-email-mhagger@alum.mit.edu> (raw)
Currently it is possible to inquire the values of particular
attributes on particular files, using either the API function
git_checkattr() or the command "git check-attr". But it is not
possible to ask for *all* attributes that are associated with a
particular file. This patch series adds that functionality:
* A new API call git_allattr()
* A new option "git check-attr --all -- pathnames"
Along the way, several small cleanups are made in the general
neighborhood, including:
* Disallow the empty string as an attribute name
* Provide access to the name attribute of git_attr
* Fail with an error message if no pathnames are provided on the
command line (and --stdin is not used)
* If --stdin is used, interpret all command-line arguments as
attribute names
* Rename struct git_attr_check to git_attr_value
Most of the patches are hopefully self-explanatory; see the individual
patch emails for discussion of changes that might potentially be
controversial.
Michael Haggerty (19):
doc: Add a link from gitattributes(5) to git-check-attr(1)
doc: Correct git_attr() calls in example code
Remove anachronism from comment
Disallow the empty string as an attribute name
git-check-attr: Add missing "&&"
git-check-attr: Add tests of command-line parsing
Provide access to the name attribute of git_attr
git-check-attr: Use git_attr_name()
Allow querying all attributes on a file
git-check-attr: Extract a function output_attr()
git-check-attr: Introduce a new variable
git-check-attr: Extract a function error_with_usage()
git-check-attr: Handle each error separately
git-check-attr: Process command-line args more systematically
git-check-attr: Error out if no pathnames are specified
git-check-attr: Add an --all option to show all attributes
git-check-attr: Drive two tests using the same raw data
git-check-attr: Fix command-line handling to match docs
Rename struct git_attr_check to git_attr_value
Documentation/git-check-attr.txt | 23 ++++-
Documentation/gitattributes.txt | 3 +
Documentation/technical/api-gitattributes.txt | 66 +++++++++-----
archive.c | 4 +-
attr.c | 61 +++++++++++--
attr.h | 24 ++++-
builtin/check-attr.c | 123 ++++++++++++++++--------
builtin/pack-objects.c | 4 +-
convert.c | 10 +-
ll-merge.c | 6 +-
t/t0003-attributes.sh | 61 +++++++++----
userdiff.c | 2 +-
ws.c | 4 +-
13 files changed, 278 insertions(+), 113 deletions(-)
--
1.7.6.8.gd2879
next reply other threads:[~2011-07-26 14:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 14:12 Michael Haggerty [this message]
2011-07-26 14:12 ` [PATCH 01/19] doc: Add a link from gitattributes(5) to git-check-attr(1) Michael Haggerty
2011-07-26 14:12 ` [PATCH 02/19] doc: Correct git_attr() calls in example code Michael Haggerty
2011-07-26 14:12 ` [PATCH 03/19] Remove anachronism from comment Michael Haggerty
2011-07-26 14:12 ` [PATCH 04/19] Disallow the empty string as an attribute name Michael Haggerty
2011-07-27 20:20 ` Junio C Hamano
2011-07-26 14:12 ` [PATCH 05/19] git-check-attr: Add missing "&&" Michael Haggerty
2011-07-26 14:12 ` [PATCH 06/19] git-check-attr: Add tests of command-line parsing Michael Haggerty
2011-07-26 14:12 ` [PATCH 07/19] Provide access to the name attribute of git_attr Michael Haggerty
2011-07-27 20:02 ` Junio C Hamano
2011-07-28 4:27 ` Michael Haggerty
2011-07-26 14:12 ` [PATCH 08/19] git-check-attr: Use git_attr_name() Michael Haggerty
2011-07-26 14:12 ` [PATCH 09/19] Allow querying all attributes on a file Michael Haggerty
2011-07-26 14:12 ` [PATCH 10/19] git-check-attr: Extract a function output_attr() Michael Haggerty
2011-07-26 14:12 ` [PATCH 11/19] git-check-attr: Introduce a new variable Michael Haggerty
2011-07-26 14:12 ` [PATCH 12/19] git-check-attr: Extract a function error_with_usage() Michael Haggerty
2011-07-26 14:12 ` [PATCH 13/19] git-check-attr: Handle each error separately Michael Haggerty
2011-07-26 14:12 ` [PATCH 14/19] git-check-attr: Process command-line args more systematically Michael Haggerty
2011-07-26 14:12 ` [PATCH 15/19] git-check-attr: Error out if no pathnames are specified Michael Haggerty
2011-07-26 14:12 ` [PATCH 16/19] git-check-attr: Add an --all option to show all attributes Michael Haggerty
2011-07-28 4:31 ` Michael Haggerty
2011-07-26 14:13 ` [PATCH 17/19] git-check-attr: Drive two tests using the same raw data Michael Haggerty
2011-07-26 14:13 ` [PATCH 18/19] git-check-attr: Fix command-line handling to match docs Michael Haggerty
2011-07-26 14:13 ` [PATCH 19/19] Rename struct git_attr_check to git_attr_value Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311689582-3116-1-git-send-email-mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).