From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Haggerty Subject: [PATCH v2 03/19] Remove anachronism from comment Date: Thu, 28 Jul 2011 06:46:42 +0200 Message-ID: <1311828418-2676-4-git-send-email-mhagger@alum.mit.edu> References: <1311828418-2676-1-git-send-email-mhagger@alum.mit.edu> Cc: git@vger.kernel.org, Michael Haggerty To: gitster@pobox.com X-From: git-owner@vger.kernel.org Thu Jul 28 06:47:42 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QmIVZ-0005eI-8I for gcvg-git-2@lo.gmane.org; Thu, 28 Jul 2011 06:47:41 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753703Ab1G1Er2 (ORCPT ); Thu, 28 Jul 2011 00:47:28 -0400 Received: from mail.berlin.jpk.com ([212.222.128.130]:57255 "EHLO mail.berlin.jpk.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752241Ab1G1ErV (ORCPT ); Thu, 28 Jul 2011 00:47:21 -0400 Received: from michael.berlin.jpk.com ([192.168.100.152]) by mail.berlin.jpk.com with esmtp (Exim 4.50) id 1QmITD-000889-95; Thu, 28 Jul 2011 06:45:15 +0200 X-Mailer: git-send-email 1.7.6.8.gd2879 In-Reply-To: <1311828418-2676-1-git-send-email-mhagger@alum.mit.edu> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Setting attributes to arbitrary values ("attribute=value") is now supported, so it is no longer necessary for this comment to justify prohibiting '=' in an attribute name. Signed-off-by: Michael Haggerty --- attr.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/attr.c b/attr.c index f6b3f7e..4a1244f 100644 --- a/attr.c +++ b/attr.c @@ -50,10 +50,8 @@ static unsigned hash_name(const char *name, int namelen) static int invalid_attr_name(const char *name, int namelen) { /* - * Attribute name cannot begin with '-' and from - * [-A-Za-z0-9_.]. We'd specifically exclude '=' for now, - * as we might later want to allow non-binary value for - * attributes, e.g. "*.svg merge=special-merge-program-for-svg" + * Attribute name cannot begin with '-' and must consist of + * characters from [-A-Za-z0-9_.]. */ if (*name == '-') return -1; -- 1.7.6.8.gd2879