From: Michael Haggerty <mhagger@alum.mit.edu>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH v3 18/23] git-check-attr: Process command-line args more systematically
Date: Thu, 4 Aug 2011 06:36:28 +0200 [thread overview]
Message-ID: <1312432593-9841-19-git-send-email-mhagger@alum.mit.edu> (raw)
In-Reply-To: <1312432593-9841-1-git-send-email-mhagger@alum.mit.edu>
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
builtin/check-attr.c | 19 ++++++++++++-------
1 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/builtin/check-attr.c b/builtin/check-attr.c
index de3fef7..e9b827f 100644
--- a/builtin/check-attr.c
+++ b/builtin/check-attr.c
@@ -81,8 +81,6 @@ int cmd_check_attr(int argc, const char **argv, const char *prefix)
argc = parse_options(argc, argv, prefix, check_attr_options,
check_attr_usage, PARSE_OPT_KEEP_DASHDASH);
- if (!argc)
- usage_with_options(check_attr_usage, check_attr_options);
if (read_cache() < 0) {
die("invalid cache");
@@ -94,8 +92,17 @@ int cmd_check_attr(int argc, const char **argv, const char *prefix)
doubledash = i;
}
- /* If there is no double dash, we handle only one attribute */
- if (doubledash < 0) {
+ /* Check attribute argument(s): */
+ if (doubledash == 0) {
+ error_with_usage("No attribute specified");
+ } else if (doubledash < 0) {
+ /*
+ * There is no double dash; treat the first
+ * argument as an attribute.
+ */
+ if (!argc)
+ error_with_usage("No attribute specified");
+
cnt = 1;
filei = 1;
} else {
@@ -103,9 +110,7 @@ int cmd_check_attr(int argc, const char **argv, const char *prefix)
filei = doubledash + 1;
}
- if (cnt <= 0)
- error_with_usage("No attribute specified");
-
+ /* Check file argument(s): */
if (stdin_paths && filei < argc)
error_with_usage("Can't specify files with --stdin");
--
1.7.6.8.gd2879
next prev parent reply other threads:[~2011-08-04 4:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 4:36 [PATCH v3 00/23] Add --all option to git-check-attr Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 01/23] doc: Add a link from gitattributes(5) to git-check-attr(1) Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 02/23] doc: Correct git_attr() calls in example code Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 03/23] Remove anachronism from comment Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 04/23] Disallow the empty string as an attribute name Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 05/23] git-check-attr: Add missing "&&" Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 06/23] git-check-attr: Add tests of command-line parsing Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 07/23] Provide access to the name attribute of git_attr Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 08/23] git-check-attr: Use git_attr_name() Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 09/23] Teach prepare_attr_stack() to figure out dirlen itself Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 10/23] Extract a function collect_all_attrs() Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 11/23] Remove redundant call to bootstrap_attr_stack() Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 12/23] Remove redundant check Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 13/23] Allow querying all attributes on a file Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 14/23] git-check-attr: Extract a function output_attr() Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 15/23] git-check-attr: Introduce a new variable Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 16/23] git-check-attr: Extract a function error_with_usage() Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 17/23] git-check-attr: Handle each error separately Michael Haggerty
2011-08-04 4:36 ` Michael Haggerty [this message]
2011-08-04 4:36 ` [PATCH v3 19/23] git-check-attr: Error out if no pathnames are specified Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 20/23] git-check-attr: Add an --all option to show all attributes Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 21/23] git-check-attr: Drive two tests using the same raw data Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 22/23] git-check-attr: Fix command-line handling to match docs Michael Haggerty
2011-08-04 4:36 ` [PATCH v3 23/23] Rename git_checkattr() to git_check_attr() Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312432593-9841-19-git-send-email-mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).