From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Haggerty Subject: [PATCH v3 03/23] Remove anachronism from comment Date: Thu, 4 Aug 2011 06:36:13 +0200 Message-ID: <1312432593-9841-4-git-send-email-mhagger@alum.mit.edu> References: <1312432593-9841-1-git-send-email-mhagger@alum.mit.edu> Cc: gitster@pobox.com, Michael Haggerty To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Thu Aug 04 06:37:11 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QopgD-0005IJ-Cd for gcvg-git-2@lo.gmane.org; Thu, 04 Aug 2011 06:37:09 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751256Ab1HDEhA (ORCPT ); Thu, 4 Aug 2011 00:37:00 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:39632 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863Ab1HDEg6 (ORCPT ); Thu, 4 Aug 2011 00:36:58 -0400 X-Envelope-From: mhagger@alum.mit.edu Received: from michael.fritz.box (p54BEB339.dip.t-dialin.net [84.190.179.57]) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id p744agHh029203; Thu, 4 Aug 2011 06:36:53 +0200 X-Mailer: git-send-email 1.7.6.8.gd2879 In-Reply-To: <1312432593-9841-1-git-send-email-mhagger@alum.mit.edu> X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 192.109.42.8 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Setting attributes to arbitrary values ("attribute=value") is now supported, so it is no longer necessary for this comment to justify prohibiting '=' in an attribute name. Signed-off-by: Michael Haggerty --- attr.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/attr.c b/attr.c index f6b3f7e..4a1244f 100644 --- a/attr.c +++ b/attr.c @@ -50,10 +50,8 @@ static unsigned hash_name(const char *name, int namelen) static int invalid_attr_name(const char *name, int namelen) { /* - * Attribute name cannot begin with '-' and from - * [-A-Za-z0-9_.]. We'd specifically exclude '=' for now, - * as we might later want to allow non-binary value for - * attributes, e.g. "*.svg merge=special-merge-program-for-svg" + * Attribute name cannot begin with '-' and must consist of + * characters from [-A-Za-z0-9_.]. */ if (*name == '-') return -1; -- 1.7.6.8.gd2879