From: Jon Seymour <jon.seymour@gmail.com>
To: git@vger.kernel.org
Cc: avarab@gmail.com, Jens.Lehmann@web.de, gitster@pobox.com,
Jon Seymour <jon.seymour@gmail.com>
Subject: [PATCH v2 0/5] gettext: add gettextln, eval_gettextln to encode common idiom
Date: Sun, 7 Aug 2011 21:58:12 +1000 [thread overview]
Message-ID: <1312718297-10999-1-git-send-email-jon.seymour@gmail.com> (raw)
Currently, if you want to use gettext or eval_gettext to format a message
you may have to add a separate echo statement and a surrounding subshell
in order to interpolate the required trailing new line.
This patch introduces two new helper functions, gettextln and eval_gettextln
which append a trailing newline to the gettext output.
This allows constructions of the form:
if test -s "$GIT_DIR/BISECT_START"
then
(
gettext "You need to give me at least one good and one bad revisions.
(You can use \"git bisect bad\" and \"git bisect good\" for that.)" &&
echo
) >&2
else
...
to be expressed more concisely as:
if test -s "$GIT_DIR/BISECT_START"
then
gettextln "You need to give me at least one good and one bad revisions.
(You can use \"git bisect bad\" and \"git bisect good\" for that.)" >&2
else
...
Applies cleanly to master and pu.
Revisions
=========
v2:
Split modifications to git-sh-i18n.sh into separate commit.
Extended application to:
git-am.sh
git-pull.sh
git-stash.sh
git-submodule.sh
Removed application to git-bisect.sh, pending stabilisation of this series and js/bisect-no-checkout in next or master.
v1: Initial RFC. Included example of application to git-bisect.sh.
Future
======
Apply to git-bisect.sh
Jon Seymour (5):
gettext: add gettextln, eval_gettextln to encode common idiom
git-am: take advantage of gettextln and eval_gettextln.
pull: take advantage of eval_gettextln
stash: take advantage of eval_gettextln
submodule: take advantage of gettextln and eval_gettextln.
git-am.sh | 31 ++++++++++++++-----------------
git-pull.sh | 7 ++-----
git-sh-i18n.sh | 19 +++++++++++++++++++
git-stash.sh | 9 +++------
git-submodule.sh | 18 ++++++------------
5 files changed, 44 insertions(+), 40 deletions(-)
--
1.7.6.363.g9b380.dirty
next reply other threads:[~2011-08-07 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-07 11:58 Jon Seymour [this message]
2011-08-07 11:58 ` [PATCH v2 1/5] gettext: add gettextln, eval_gettextln to encode common idiom Jon Seymour
2011-08-07 11:58 ` [PATCH v2 2/5] git-am: take advantage of gettextln and eval_gettextln Jon Seymour
2011-08-07 11:58 ` [PATCH v2 3/5] pull: take advantage of eval_gettextln Jon Seymour
2011-08-07 11:58 ` [PATCH v2 4/5] stash: " Jon Seymour
2011-08-07 11:58 ` [PATCH v2 5/5] submodule: take advantage of gettextln and eval_gettextln Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312718297-10999-1-git-send-email-jon.seymour@gmail.com \
--to=jon.seymour@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).