From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Christian Couder <chriscool@tuxfamily.org>,
Daniel Barkalow <barkalow@iabervon.org>,
Jeff King <peff@peff.net>
Subject: [PATCH 2/6] revert: Free memory after get_message call
Date: Fri, 12 Aug 2011 00:21:41 +0530 [thread overview]
Message-ID: <1313088705-32222-3-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1313088705-32222-1-git-send-email-artagnon@gmail.com>
The format_todo function leaks memory because it forgets to call
free_message after get_message. Fix this.
Suggested-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
builtin/revert.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/builtin/revert.c b/builtin/revert.c
index a548a14..1a4187a 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -688,6 +688,7 @@ static int format_todo(struct strbuf *buf, struct commit_list *todo_list,
return error(_("Cannot get commit message for %s"), sha1_abbrev);
strbuf_addf(buf, "%s %s %s\n", action_str, sha1_abbrev, msg.subject);
}
+ free_message(&msg);
return 0;
}
--
1.7.6.351.gb35ac.dirty
next prev parent reply other threads:[~2011-08-11 18:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 18:51 [PATCH 0/6] Towards a generalized sequencer Ramkumar Ramachandra
2011-08-11 18:51 ` [PATCH 1/6] revert: Don't remove the sequencer state on error Ramkumar Ramachandra
2011-08-11 19:20 ` Jonathan Nieder
2011-08-13 12:33 ` Ramkumar Ramachandra
2011-08-11 18:51 ` Ramkumar Ramachandra [this message]
2011-08-11 19:24 ` [PATCH 2/6] revert: Free memory after get_message call Jonathan Nieder
2011-08-12 2:07 ` Ramkumar Ramachandra
2011-08-11 18:51 ` [PATCH 3/6] revert: Parse instruction sheet more cautiously Ramkumar Ramachandra
2011-08-11 19:47 ` Jonathan Nieder
2011-08-11 18:51 ` [PATCH 4/6] revert: Allow mixed pick and revert instructions Ramkumar Ramachandra
2011-08-11 20:12 ` Jonathan Nieder
2011-08-13 16:07 ` Ramkumar Ramachandra
2011-08-11 18:51 ` [PATCH 5/6] sequencer: Expose API to cherry-picking machinery Ramkumar Ramachandra
2011-08-11 20:16 ` Jonathan Nieder
2011-08-11 21:56 ` Jonathan Nieder
2011-08-11 23:47 ` Junio C Hamano
2011-08-13 14:00 ` Ramkumar Ramachandra
2011-08-13 16:45 ` Daniel Barkalow
2011-08-13 17:40 ` Ramkumar Ramachandra
2011-08-13 17:50 ` Reusing changes after renaming a file (Re: [PATCH 5/6] sequencer: Expose API to cherry-picking machinery) Jonathan Nieder
2011-08-13 18:20 ` Ramkumar Ramachandra
2011-08-13 18:32 ` Jonathan Nieder
2011-08-13 17:06 ` [PATCH 5/6] sequencer: Expose API to cherry-picking machinery Jonathan Nieder
2011-08-13 20:54 ` Ramkumar Ramachandra
2011-08-11 18:51 ` [PATCH 6/6] sequencer: Remove sequencer state after final commit Ramkumar Ramachandra
2011-08-11 20:17 ` Jonathan Nieder
2011-08-12 2:19 ` Ramkumar Ramachandra
2011-08-11 19:03 ` [PATCH 0/6] Towards a generalized sequencer Jonathan Nieder
2011-08-12 2:14 ` Ramkumar Ramachandra
2011-08-12 2:33 ` Jonathan Nieder
2011-08-12 3:17 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313088705-32222-3-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=barkalow@iabervon.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).