git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Ivankov <divanorama@gmail.com>
To: git@vger.kernel.org
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	David Barr <davidbarr@google.com>,
	Dmitry Ivankov <divanorama@gmail.com>
Subject: [PATCH 0/2] fast-import: tag any object by sha1
Date: Mon, 22 Aug 2011 18:10:17 +0600	[thread overview]
Message-ID: <1314015019-6636-1-git-send-email-divanorama@gmail.com> (raw)

fast-export can export annotated tags that annotate any type of object.
It specifies objects via mark references and fast-import accepts this.

fast-import also allows to specify objects via sha1, and to query sha1
for a object being imported. So it should allow to tag a pre-existing
or being-imported objects by their sha1. And it currently does not:
- for pre-existing it kind of assumes it is a OBJ_COMMIT, read_sha1_file()s
  and checks only for (size >= 46), weird
- for being-imported objects it calls read_sha1_file too and fails

Just make it produce expected tags in these cases. Add a test for this.

Dmitry Ivankov (2):
  fast-import: add tests for tagging blobs
  fast-import: allow to tag newly created objects

 fast-import.c          |   14 +++++-----
 t/t9300-fast-import.sh |   67 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 74 insertions(+), 7 deletions(-)

-- 
1.7.3.4

             reply	other threads:[~2011-08-22 12:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 12:10 Dmitry Ivankov [this message]
2011-08-22 12:10 ` [PATCH 1/2] fast-import: add tests for tagging blobs Dmitry Ivankov
2011-08-22 12:10 ` [PATCH 2/2] fast-import: allow to tag newly created objects Dmitry Ivankov
2011-08-23 18:32   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314015019-6636-1-git-send-email-divanorama@gmail.com \
    --to=divanorama@gmail.com \
    --cc=davidbarr@google.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).