From: Ben Walton <bwalton@artsci.utoronto.ca>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Ben Walton <bwalton@artsci.utoronto.ca>
Subject: [PATCH] Mark http-fetch without -a as deprecated
Date: Mon, 22 Aug 2011 20:51:43 -0400 [thread overview]
Message-ID: <1314060703-24265-1-git-send-email-bwalton@artsci.utoronto.ca> (raw)
As the use of http-fetch without -a can create an object store that is
invalid to the point where it cannot even be fsck'd, mark it as
deprecated. A future release should change the default and then
remove the option entirely.
Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
---
http-fetch.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/http-fetch.c b/http-fetch.c
index 3af4c71..003ddb7 100644
--- a/http-fetch.c
+++ b/http-fetch.c
@@ -56,6 +56,9 @@ int main(int argc, const char **argv)
commits = 1;
}
+ if (get_all == 0)
+ warning("http-fetch: use without -a is deprecated; -a will become the default in a future release");
+
if (argv[arg])
str_end_url_with_slash(argv[arg], &url);
--
1.7.4.1
next reply other threads:[~2011-08-23 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 0:51 Ben Walton [this message]
2011-08-23 7:02 ` [PATCH] Mark http-fetch without -a as deprecated Matthieu Moy
2011-08-23 13:05 ` Ben Walton
2011-08-24 0:29 ` Ben Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314060703-24265-1-git-send-email-bwalton@artsci.utoronto.ca \
--to=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).