From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: [PATCH 1/2] fast-import: initialize variable require_explicit_termination
Date: Fri, 26 Aug 2011 19:11:28 +0200 [thread overview]
Message-ID: <1314378689-8997-1-git-send-email-Matthieu.Moy@imag.fr> (raw)
The uninitialized variable seems harmless in practice, but let's still be clean.
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
For some reason, remote helpers seem to be forced to use the "done"
command now. Investing why, I found this, but that wasn't what I was
looking for.
fast-import.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fast-import.c b/fast-import.c
index 7cc2262..ed8f3cd 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -355,7 +355,7 @@ static unsigned int cmd_save = 100;
static uintmax_t next_mark;
static struct strbuf new_data = STRBUF_INIT;
static int seen_data_command;
-static int require_explicit_termination;
+static int require_explicit_termination = 0;
/* Signal handling */
static volatile sig_atomic_t checkpoint_requested;
--
1.7.6.585.g5929f.dirty
next reply other threads:[~2011-08-26 17:11 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 17:11 Matthieu Moy [this message]
2011-08-26 17:11 ` [PATCH 2/2] Add a remote helper to interact with mediawiki (fetch & push) Matthieu Moy
2011-08-26 17:53 ` Junio C Hamano
2011-08-29 5:42 ` Sverre Rabbelier
2011-08-29 6:05 ` Junio C Hamano
2011-08-29 6:41 ` Sverre Rabbelier
2011-08-30 3:56 ` Jonathan Nieder
2011-08-30 17:13 ` Junio C Hamano
2011-08-31 11:54 ` Matthieu Moy
2011-09-01 23:44 ` Jonathan Nieder
2011-08-31 12:05 ` done feature in remote-helpers (was Re: [PATCH 2/2] Add a remote helper to interact with mediawiki (fetch & push)) Matthieu Moy
2011-08-31 12:17 ` Sverre Rabbelier
2011-08-31 12:55 ` Matthieu Moy
2011-08-31 12:58 ` Sverre Rabbelier
2011-08-31 13:12 ` Matthieu Moy
2011-08-31 13:16 ` Sverre Rabbelier
2011-08-31 16:47 ` [PATCH] git-remote-helpers.txt: explain how import works with multiple refs Matthieu Moy
2011-08-31 18:14 ` [PATCH] (short) documentation for the testgit remote helper Matthieu Moy
2011-09-01 11:27 ` Sverre Rabbelier
2011-09-01 15:52 ` Matthieu Moy
2011-09-01 16:49 ` [PATCH 1/2 v2] Documentation/git-remote-helpers: explain how import works with multiple refs Matthieu Moy
2011-09-01 16:49 ` [PATCH 2/2 v2] (short) documentation for the testgit remote helper Matthieu Moy
2011-09-01 16:59 ` Sverre Rabbelier
2011-09-01 16:59 ` [PATCH 1/2 v2] Documentation/git-remote-helpers: explain how import works with multiple refs Sverre Rabbelier
2011-09-01 11:24 ` [PATCH] git-remote-helpers.txt: " Sverre Rabbelier
2011-09-01 23:17 ` Jonathan Nieder
2011-09-03 10:35 ` Matthieu Moy
2011-08-26 17:55 ` [PATCH v5] Add a remote helper to interact with mediawiki (fetch & push) Matthieu Moy
2011-08-31 16:55 ` [PATCH v6] " Matthieu Moy
2011-08-31 17:03 ` Sverre Rabbelier
2011-08-31 17:30 ` Matthieu Moy
2011-09-01 0:24 ` Junio C Hamano
2011-09-01 5:26 ` Matthieu Moy
2011-09-01 16:54 ` [PATCH 0/2] Git-MediaWiki Matthieu Moy
2011-09-01 16:54 ` [PATCH 1/2 v7] Add a remote helper to interact with mediawiki (fetch & push) Matthieu Moy
2011-09-01 16:54 ` [PATCH 2/2] git-remote-mediawiki: allow push to set MediaWiki metadata Matthieu Moy
2011-08-31 12:33 ` Clean termination of remote-helpers (was Re: [PATCH 2/2] Add a remote helper to interact with mediawiki (fetch & push)) Matthieu Moy
2011-08-31 13:25 ` Sverre Rabbelier
2011-08-31 14:53 ` Matthieu Moy
2011-08-31 15:00 ` Sverre Rabbelier
2011-08-26 17:51 ` [PATCH 1/2] fast-import: initialize variable require_explicit_termination Junio C Hamano
2011-08-26 17:59 ` Matthieu Moy
2011-08-26 18:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314378689-8997-1-git-send-email-Matthieu.Moy@imag.fr \
--to=matthieu.moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).