git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marat Radchenko <marat@slonopotamus.org>
To: Tay Ray Chuan <rctay89@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] xdiff/xprepare: improve O(n*m) performance in xdl_cleanup_records()
Date: Sat, 27 Aug 2011 12:50:31 +0400	[thread overview]
Message-ID: <1314435031.9095.2.camel@n900.home.ru> (raw)
In-Reply-To: <1313546037-4104-1-git-send-email-rctay89@gmail.com>

On ср 17 авг 2011 05:53:57 MSD, Tay Ray Chuan <rctay89@gmail.com> wrote:

> In xdl_cleanup_records(), we see O(n*m) performance, where n is the
> number of records from xdf->dstart to xdf->dend, and m is the size of a
> bucket in xdf->rhash (<= by mlim).
> 
> Here, we improve this to O(n) by pre-computing nm (in rcrec->len(1|2))
> in xdl_classify_record().

Thanks for your patch, btw, now diff is much faster

      parent reply	other threads:[~2011-08-27  8:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09  7:51 git diff is slow (--patience is fast) Marat Radchenko
2011-08-09 10:49 ` Tay Ray Chuan
2011-08-09 11:39   ` Marat Radchenko
2011-08-16  3:01     ` Tay Ray Chuan
2011-08-16  3:11 ` [PATCH] xdiff/xprepare: improve O(n*m) performance in xdl_cleanup_records() Tay Ray Chuan
2011-08-16  3:37   ` Tay Ray Chuan
2011-08-16 17:39     ` Junio C Hamano
2011-08-17  1:53       ` [PATCH v2] " Tay Ray Chuan
2011-08-17  5:21         ` Jeff King
2011-08-17 15:55           ` Tay Ray Chuan
2011-08-18 22:44             ` Jeff King
2011-08-19 17:12               ` Tay Ray Chuan
2011-08-21  9:24                 ` Johannes Sixt
2011-08-24  6:29         ` Marat Radchenko
2011-08-24  6:32           ` Marat Radchenko
2011-08-27  8:50         ` Marat Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314435031.9095.2.camel@n900.home.ru \
    --to=marat@slonopotamus.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rctay89@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).