git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Vandiver <alex@chmrr.net>
To: Jeff King <peff@peff.net>
Cc: Thomas Rast <trast@student.ethz.ch>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] test-lib: save test counts across invocations
Date: Thu, 01 Sep 2011 14:38:54 -0400	[thread overview]
Message-ID: <1314902334.5371.17.camel@umgah.localdomain> (raw)
In-Reply-To: <20110901163846.GD15018@sigill.intra.peff.net>

On Thu, 2011-09-01 at 12:38 -0400, Jeff King wrote:
> Hmm. What happens when we're wrong? Does our eye-candy just print
> something non-sensical like "13/12", or does prove actually care that we
> run the right number of tests?

prove very much does care -- having a mismatch between the number of
tests planned and the number of tests run is an error in the testfile,
and is reported as such in big red text.  This is because stating how
many tests you plan to run gives prove a way (in addition to the exit
status) to know if the test stopped prematurely, so all mismatches
between plan and actual test counts are reported as testfile failures.

As far as I know prove doesn't have a way to print the estimated time
remaining, though using the contents of the .prove file (if you ran
prove --state=save) to guess it wouldn't be all that hard of a change.
 - Alex

  reply	other threads:[~2011-09-01 18:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-01 13:08 [PATCH] test-lib: save test counts across invocations Thomas Rast
2011-09-01 16:14 ` Junio C Hamano
2011-09-01 16:38 ` Jeff King
2011-09-01 18:38   ` Alex Vandiver [this message]
2011-09-01 18:45     ` Jeff King
2011-09-02 12:39   ` Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314902334.5371.17.camel@umgah.localdomain \
    --to=alex@chmrr.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).