From: Clemens Buchacher <drizzd@aon.at>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
tobiasu@tmux.org, Clemens Buchacher <drizzd@aon.at>
Subject: [PATCH 2/3] fix push --quiet via http
Date: Sat, 3 Sep 2011 18:34:15 +0200 [thread overview]
Message-ID: <1315067656-2846-3-git-send-email-drizzd@aon.at> (raw)
In-Reply-To: <1315067656-2846-1-git-send-email-drizzd@aon.at>
A verbosity of 0 means quiet for remote helpers.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
remote-curl.c | 2 +-
t/t5541-http-push.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/remote-curl.c b/remote-curl.c
index 5798aa5..2341106 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -762,7 +762,7 @@ static int push_git(struct discovery *heads, int nr_spec, char **specs)
argv[argc++] = "--thin";
if (options.dry_run)
argv[argc++] = "--dry-run";
- if (options.verbosity < 0)
+ if (options.verbosity == 0)
argv[argc++] = "--quiet";
else if (options.verbosity > 1)
argv[argc++] = "--verbose";
diff --git a/t/t5541-http-push.sh b/t/t5541-http-push.sh
index 0dcb8df..e756a08 100755
--- a/t/t5541-http-push.sh
+++ b/t/t5541-http-push.sh
@@ -155,7 +155,7 @@ test_expect_success 'push (chunked)' '
test $HEAD = $(git rev-parse --verify HEAD))
'
-test_expect_failure TTY 'quiet push' '
+test_expect_success TTY 'quiet push' '
cd "$ROOT_PATH"/test_repo_clone &&
test_commit quiet &&
test_terminal git push --quiet --no-progress 2>&1 | tee output &&
--
1.7.6.1
next prev parent reply other threads:[~2011-09-03 16:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 10:57 [BUG] git push --quiet fails with older versions Tobias Ulmer
2011-09-03 16:34 ` Clemens Buchacher
2011-09-03 16:34 ` [PATCH 1/3] tests for push --quiet Clemens Buchacher
2011-09-03 16:34 ` Clemens Buchacher [this message]
2011-09-03 16:34 ` [PATCH 3/3] push: old receive-pack does not understand --quiet Clemens Buchacher
2011-09-05 2:28 ` Junio C Hamano
2011-09-05 3:01 ` Junio C Hamano
2011-09-05 8:35 ` Junio C Hamano
2011-09-05 9:23 ` Michael J Gruber
2011-09-05 14:17 ` Michael J Gruber
2011-09-05 14:24 ` [PATCH] t5541: avoid TAP test miscounting Michael J Gruber
2011-09-05 19:34 ` [PATCH 3/3] push: old receive-pack does not understand --quiet Junio C Hamano
2011-09-06 6:03 ` Michael J Gruber
2011-09-06 18:01 ` Junio C Hamano
2011-09-06 19:52 ` Clemens Buchacher
2011-09-04 12:08 ` [BUG] git push --quiet fails with older versions Tobias Ulmer
2011-09-04 19:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315067656-2846-3-git-send-email-drizzd@aon.at \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tobiasu@tmux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).