git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Gernhardt <brian@gernhardtsoftware.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] Un-static gitmkstemps
Date: Thu, 15 Sep 2011 08:21:00 -0400	[thread overview]
Message-ID: <1316089260-76049-1-git-send-email-brian@gernhardtsoftware.com> (raw)

It may not be used in most builds, but it's used via a #ifdef in
git-compat-util.h  Also, making it static makes a -Wall compile fail
since it's not used in the file without NO_MKSTEMPS.

Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
---

 Either this, or it should be removed from git-compat-util and wrapped in
 an #ifdef.  (The only current user is git_mkstemps), but since it's
 referenced in a header file, I figured it shouldn't be static.

 wrapper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/wrapper.c b/wrapper.c
index 390a7ae..1c41488 100644
--- a/wrapper.c
+++ b/wrapper.c
@@ -310,7 +310,7 @@ int git_mkstemp_mode(char *pattern, int mode)
 	return git_mkstemps_mode(pattern, 0, mode);
 }
 
-static int gitmkstemps(char *pattern, int suffix_len)
+int gitmkstemps(char *pattern, int suffix_len)
 {
 	return git_mkstemps_mode(pattern, suffix_len, 0600);
 }
-- 
1.7.7.rc0.309.g13ed2.dirty

             reply	other threads:[~2011-09-15 12:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15 12:21 Brian Gernhardt [this message]
2011-09-15 16:05 ` [PATCH] Un-static gitmkstemps Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316089260-76049-1-git-send-email-brian@gernhardtsoftware.com \
    --to=brian@gernhardtsoftware.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).