git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luke Diamand <luke@diamand.org>
To: git@vger.kernel.org
Cc: pw@padd.com, vitor.hda@gmail.com, Luke Diamand <luke@diamand.org>
Subject: [RFC/PATCHv2] git-p4: handle files with shell metacharacters
Date: Tue, 27 Sep 2011 09:40:35 +0100	[thread overview]
Message-ID: <1317112836-14135-1-git-send-email-luke@diamand.org> (raw)
In-Reply-To: <20110926214758.GB3433@arf.padd.com>

Updated git-p4 changes incorporating Pete's comments.

 - p4CmdList's stdin argument can now be a list.

 - Getting rid of the string option entirely is very hard; there are
   places where currently git-p4 creates a pipeline.

 - I wonder if verbose should actually be enabled for all the test
   cases?

 - The $ENV{PWD} is needed now because the shell used to set that; now
   that the shell isn't in use git-p4 has to set it.

Pete - I wasn't sure whether you were saying I should rework
my patch against next (and you would then rework your series) or
something else. That sounds complicated though - let me know!

Thanks!
Luke

Luke Diamand (1):
  git-p4: handle files with shell metacharacters

 contrib/fast-import/git-p4     |  200 ++++++++++++++++++++++++---------------
 t/t9803-git-shell-metachars.sh |   70 ++++++++++++++
 2 files changed, 193 insertions(+), 77 deletions(-)
 create mode 100755 t/t9803-git-shell-metachars.sh

-- 
1.7.6.347.g4db0d

  reply	other threads:[~2011-09-27  8:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26 21:29 [PATCH/RFCv1] git-p4: handle files with shell metacharacters Luke Diamand
2011-09-26 21:29 ` Luke Diamand
2011-09-26 21:47   ` Pete Wyckoff
2011-09-27  8:40     ` Luke Diamand [this message]
2011-09-27  8:40       ` [RFC/PATCHv2] " Luke Diamand
2011-09-27  9:32       ` Luke Diamand
2011-09-27 13:03       ` Pete Wyckoff
2011-09-30  9:06         ` Luke Diamand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317112836-14135-1-git-send-email-luke@diamand.org \
    --to=luke@diamand.org \
    --cc=git@vger.kernel.org \
    --cc=pw@padd.com \
    --cc=vitor.hda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).