git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: karl <karl.okeeffe@kuluvalley.com>
To: git@vger.kernel.org
Subject: Re: Problems with git-svn and space in the URL
Date: Wed, 28 Sep 2011 07:04:41 -0700 (PDT)	[thread overview]
Message-ID: <1317218681291-6840304.post@n2.nabble.com> (raw)
In-Reply-To: <0A790195-2DB1-4E1F-BAE2-9D65C261AD26@sky4studios.be>

I was able to work around this issue by patching git-svn.

I updated the url_path function to:


sub url_path {
	my ($self, $path) = @_;

	my $url = $self->{url} . '/' . $self->repo_path($path);
	if ($self->{url} =~ m#^https?://#) {
		$url =~ s!([^~a-zA-Z0-9_./-])!uc sprintf("%%%02x",ord($1))!eg;
                $url =~ s!^(https?)%3A//!$1://!;
	}
    $url
}


This ensures that the spaces in the url are encoded correctly.

It seems to work for me, but hasn't been tested thoroughly.

--
View this message in context: http://git.661346.n2.nabble.com/Problems-with-git-svn-and-space-in-the-URL-tp5120361p6840304.html
Sent from the git mailing list archive at Nabble.com.

      reply	other threads:[~2011-09-28 14:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-31  3:05 Problems with git-svn and space in the URL Marc Van Olmen
2010-05-31 15:33 ` Marc Van Olmen
2011-09-28 14:04   ` karl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317218681291-6840304.post@n2.nabble.com \
    --to=karl.okeeffe@kuluvalley.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).