git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
	Daniel Barkalow <barkalow@iabervon.org>,
	Christian Couder <chriscool@tuxfamily.org>
Subject: [PATCH 2/6] revert: Simplify getting commit subject
Date: Sat,  8 Oct 2011 23:06:43 +0530	[thread overview]
Message-ID: <1318095407-26429-3-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1318095407-26429-1-git-send-email-artagnon@gmail.com>

The heavy parsing and memory allocations performed by get_message is
unnecessary when only the commit subject is desired.  Use
find_commit_subject instead.

Suggested-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 builtin/revert.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/builtin/revert.c b/builtin/revert.c
index a2c304d..b3c5e0e 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -673,16 +673,16 @@ static int format_todo(struct strbuf *buf, struct commit_list *todo_list,
 		struct replay_opts *opts)
 {
 	struct commit_list *cur = NULL;
-	struct commit_message msg = { NULL, NULL, NULL, NULL, NULL };
 	const char *sha1_abbrev = NULL;
 	const char *action_str = opts->action == REVERT ? "revert" : "pick";
+	const char *subject;
+	int subject_len;
 
 	for (cur = todo_list; cur; cur = cur->next) {
 		sha1_abbrev = find_unique_abbrev(cur->item->object.sha1, DEFAULT_ABBREV);
-		if (get_message(cur->item, &msg))
-			return error(_("Cannot get commit message for %s"), sha1_abbrev);
-		strbuf_addf(buf, "%s %s %s\n", action_str, sha1_abbrev, msg.subject);
-		free_message(&msg);
+		subject_len = find_commit_subject(cur->item->buffer, &subject);
+		strbuf_addf(buf, "%s %s %.*s\n", action_str, sha1_abbrev,
+			subject_len, subject);
 	}
 	return 0;
 }
-- 
1.7.4.1

  parent reply	other threads:[~2011-10-08 17:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-08 17:36 [PATCH 0/6] Sequencer fixups mini-series Ramkumar Ramachandra
2011-10-08 17:36 ` [PATCH 1/6] revert: Free memory after get_message call Ramkumar Ramachandra
2011-10-08 17:36 ` Ramkumar Ramachandra [this message]
2011-10-08 17:36 ` [PATCH 3/6] revert: Fix buffer overflow in insn sheet parser Ramkumar Ramachandra
2011-10-08 17:36 ` [PATCH 4/6] revert: Make commit descriptions in insn sheet optional Ramkumar Ramachandra
2011-10-10 17:54   ` Junio C Hamano
2011-10-12 21:05     ` Junio C Hamano
2011-10-17 10:06       ` Ramkumar Ramachandra
2011-10-08 17:36 ` [PATCH 5/6] revert: Allow mixed pick and revert instructions Ramkumar Ramachandra
2011-10-08 17:36 ` [PATCH 6/6] revert: Simplify passing command-line arguments around Ramkumar Ramachandra
2011-10-09  2:14   ` Tay Ray Chuan
2011-10-09  8:28     ` Ramkumar Ramachandra
2011-10-09  8:53       ` Jonathan Nieder
2011-10-09  9:04         ` Ramkumar Ramachandra
2011-10-09  9:24           ` Jonathan Nieder
2011-10-17 10:10             ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318095407-26429-3-git-send-email-artagnon@gmail.com \
    --to=artagnon@gmail.com \
    --cc=barkalow@iabervon.org \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).