From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Haggerty Subject: [PATCH v3 2/7] invalidate_ref_cache(): take the submodule as parameter Date: Wed, 12 Oct 2011 20:44:22 +0200 Message-ID: <1318445067-19279-3-git-send-email-mhagger@alum.mit.edu> References: <7vty7ggzum.fsf@alter.siamese.dyndns.org> <1318445067-19279-1-git-send-email-mhagger@alum.mit.edu> Cc: git@vger.kernel.org, Jeff King , Drew Northup , Jakub Narebski , Heiko Voigt , Johan Herland , Julian Phillips , Michael Haggerty To: Junio C Hamano X-From: git-owner@vger.kernel.org Wed Oct 12 20:50:06 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RE3sT-0006Yt-IF for gcvg-git-2@lo.gmane.org; Wed, 12 Oct 2011 20:50:05 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753998Ab1JLStk (ORCPT ); Wed, 12 Oct 2011 14:49:40 -0400 Received: from mail.berlin.jpk.com ([212.222.128.130]:58198 "EHLO mail.berlin.jpk.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753047Ab1JLStj (ORCPT ); Wed, 12 Oct 2011 14:49:39 -0400 Received: from michael.berlin.jpk.com ([192.168.100.152]) by mail.berlin.jpk.com with esmtp (Exim 4.50) id 1RE3mR-0008JO-Bq; Wed, 12 Oct 2011 20:43:51 +0200 X-Mailer: git-send-email 1.7.7.rc2 In-Reply-To: <1318445067-19279-1-git-send-email-mhagger@alum.mit.edu> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Instead of invalidating the ref cache on an all-or-nothing basis, allow the cache for individual submodules to be invalidated. Signed-off-by: Michael Haggerty --- refs.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/refs.c b/refs.c index 120b8e4..cc72609 100644 --- a/refs.c +++ b/refs.c @@ -202,13 +202,9 @@ static struct cached_refs *get_cached_refs(const char *submodule) return refs; } -static void invalidate_ref_cache(void) +static void invalidate_ref_cache(const char *submodule) { - struct cached_refs *refs = cached_refs; - while (refs) { - clear_cached_refs(refs); - refs = refs->next; - } + clear_cached_refs(get_cached_refs(submodule)); } static void read_packed_refs(FILE *f, struct ref_array *array) @@ -1228,7 +1224,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt) ret |= repack_without_ref(refname); unlink_or_warn(git_path("logs/%s", lock->ref_name)); - invalidate_ref_cache(); + invalidate_ref_cache(NULL); unlock_ref(lock); return ret; } @@ -1527,7 +1523,7 @@ int write_ref_sha1(struct ref_lock *lock, unlock_ref(lock); return -1; } - invalidate_ref_cache(); + invalidate_ref_cache(NULL); if (log_ref_write(lock->ref_name, lock->old_sha1, sha1, logmsg) < 0 || (strcmp(lock->ref_name, lock->orig_ref_name) && log_ref_write(lock->orig_ref_name, lock->old_sha1, sha1, logmsg) < 0)) { -- 1.7.7.rc2